make app ids more unique #6113
Merged
make app ids more unique #6113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarth
reviewed
Sep 28, 2016
| @@ -6,6 +6,8 @@ import 'dart:async'; | |||
| import 'dart:convert'; | |||
| import 'dart:io'; | |||
|
|
|||
| import 'package:usage/src/uuid.dart'; // ignore: implementation_imports | |||
There was a problem hiding this comment.
Maybe it would be better to duplicate this code instead of importing something private? It looks pretty self-contained.
There was a problem hiding this comment.
I maintain package:usage, so while this is a bit of a shortcut I felt not much risk of APIs changing out from under us.
But I can inline the class - it is self-contained and small.
There was a problem hiding this comment.
Maybe package:usage should export it in its API?
Anyway, its up to you.
|
LGTM |
danrubel
approved these changes
Sep 28, 2016
| @@ -6,6 +6,8 @@ import 'dart:async'; | |||
| import 'dart:convert'; | |||
| import 'dart:io'; | |||
|
|
|||
| import 'package:usage/src/uuid.dart'; // ignore: implementation_imports | |||
There was a problem hiding this comment.
I agree with Adam that it would be cleaner if the package exported the needed API.
There was a problem hiding this comment.
I'll inline this for now and file an issue to expose the API in usage.
Merged
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When returning launched app ids to clients, instead of generating ids using an increasing number (
app-1,app-2, ...), use 128bit uuids. This makes them unique across daemon instances, which can be useful to clients that use multiple daemon instances.@danrubel, /cc @stevemessick