Skip to content

Reload pause #6459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 21, 2016
Merged

Reload pause #6459

merged 4 commits into from
Oct 21, 2016

Conversation

@devoncarew
Copy link
Contributor

@devoncarew devoncarew commented Oct 21, 2016

  • add a pause parameter to the reload command
  • have app.reload return a status result (code, message) instead of a boolean
  • fix an issue where, when rejected a reload, we never complete a status object. This causes the IDE progress message to never complete.

@johnmccutchan @danrubel

@johnmccutchan
Copy link
Contributor

johnmccutchan commented Oct 21, 2016

lgtm

@devoncarew devoncarew merged commit 55a374d into flutter:master Oct 21, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devoncarew @johnmccutchan