Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Reland "Make sure all isolates start during flutter driver tests"" #65635

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

renyou
Copy link
Contributor

@renyou renyou commented Sep 11, 2020

Reverts #64432

This breaks internal test, see b/168295046

@renyou renyou requested a review from dnfield September 11, 2020 13:25
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Sep 11, 2020
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tvolkert
Copy link
Contributor

@speaking-in-code also see #24703 (comment)

@renyou renyou merged commit 51bb11f into master Sep 11, 2020
@renyou renyou deleted the revert-64432-master branch September 11, 2020 21:15
renyou added a commit to renyou/flutter that referenced this pull request Sep 11, 2020
renyou added a commit that referenced this pull request Sep 11, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants