Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icons] Update icon version to point to file that iOS will prefer. #66524

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

willlarche
Copy link
Member

Description

iOS didn't like that we had renamed our icon file without changing the name table. Fonts team helped us get the name table changed.

Related Issues

Closes #65991

Tests

I added the following tests:
I don't believe we can have tests for validating .ipa files on Apple's AppStore.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@xster
Copy link
Member

xster commented Sep 24, 2020

LGTM

Copy link
Contributor

@JoseAlba JoseAlba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

██╗      ██████╗ ████████╗███╗   ███╗
██║     ██╔════╝ ╚══██╔══╝████╗ ████║
██║     ██║  ███╗   ██║   ██╔████╔██║
██║     ██║   ██║   ██║   ██║╚██╔╝██║
███████╗╚██████╔╝   ██║   ██║ ╚═╝ ██║
╚══════╝ ╚═════╝    ╚═╝   ╚═╝     ╚═╝

@willlarche willlarche added platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management waiting for tree to go green labels Sep 24, 2020
@fluttergithubbot fluttergithubbot merged commit 67f51e8 into flutter:master Sep 24, 2020
@willlarche willlarche deleted the fix-icont-font-ios branch September 25, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS 14 release Invalid Binary related to Invalid font when adding a Widget Extension
6 participants