Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailed RenderBox and RenderObject docs #6745

Merged
merged 1 commit into from
Nov 8, 2016
Merged

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Nov 7, 2016

No description provided.

@Hixie
Copy link
Contributor Author

Hixie commented Nov 7, 2016

@abarth

///
/// #### Using RenderShiftedBox
///
/// By default, a [RenderShiftedBox] acts much like a [R]enderProxyBox but
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[R] ?

///
/// @override
/// void performResize() {
/// size = constraints.biggest;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to recommend biggest? That will blow up with infinite constraints.

///
/// To describe how a render box paints, implement the [paint] method. It is
/// given a [PaintingContext] object and an [Offset]. The offset specifies the
/// position that the box should consider as its top left corner. The painting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its top left corner...

in the coordinate system of context.canvas

/// 1. creation (constructor runs)
/// 2. properties get modified
/// 3. layout
/// 4. paint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantics?

///
/// ### Lifecycle
///
/// The lifecycle of a [RenderObject] is roughly as follows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about attach/detach?

@abarth
Copy link
Contributor

abarth commented Nov 7, 2016

LGTM

@Hixie
Copy link
Contributor Author

Hixie commented Nov 8, 2016

Made fixes, will land when Travis agrees.

@Hixie Hixie merged commit 106ff33 into flutter:master Nov 8, 2016
@Hixie Hixie deleted the boxdoc branch November 8, 2016 23:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants