Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make scrollbar assertions less aggressive #84809

Merged
merged 11 commits into from
Jun 23, 2021
Merged

Make scrollbar assertions less aggressive #84809

merged 11 commits into from
Jun 23, 2021

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Jun 17, 2021

This adjusts the assertions on interactive scrollbars to only be applied when the scrollbar is visible.

Related issues:

This also adds more documentation and code samples. I cleaned up a bit, removing outstanding todos and fixing some abbreviations in the tests.

For some of the removed todos, I filed issues to actually track the feature requests. 🙃

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests team Infra upgrades, team productivity, code health, technical debt. See also team: labels. framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation a: error message Error messages from the Flutter framework c: tech-debt Technical debt, code quality, testing, etc. labels Jun 17, 2021
@flutter-dashboard flutter-dashboard bot added the f: cupertino flutter/packages/flutter/cupertino repository label Jun 17, 2021
@google-cla google-cla bot added the cla: yes label Jun 17, 2021
@Piinks Piinks requested a review from dnfield June 17, 2021 21:05
@davidmartos96
Copy link
Contributor

davidmartos96 commented Jun 18, 2021 •
edited
Loading

I like the proposed changes. Delaying the assertion to when the scrollbar has been interacted with, will help a lot to tell which scrollbar in the tree is incorrect. The error in the gallery project was a bit confusing.

@Piinks Piinks requested a review from dnfield June 21, 2021 23:38
@Piinks
Copy link
Contributor Author

Piinks commented Jun 21, 2021

Delaying the assertion to when the scrollbar has been interacted with, will help a lot to tell which scrollbar in the tree is incorrect.

This should only delay it until it is visible and available for interaction. :)

dnfield
dnfield approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the example, really helpful

Lgtm

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux flutter_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 40d0c69 into flutter:master Jun 23, 2021
davidmartos96 pushed a commit to davidmartos96/flutter that referenced this pull request Jun 25, 2021
@Piinks @davidmartos96
Make scrollbar assertions less aggressive (flutter#84809)
62ba020
@Albert221 Albert221 mentioned this pull request Nov 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnfield dnfield dnfield approved these changes

Assignees
No one assigned
Labels
a: error message Error messages from the Flutter framework a: tests "flutter test", flutter_test, or one of our tests c: tech-debt Technical debt, code quality, testing, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrollbar throws due to recent assert changes
4 participants
@Piinks @davidmartos96 @fluttergithubbot @dnfield