Skip to content

Conversation

@mpcomplete
Copy link
Contributor

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably open a separate github repo for "third party services" and have this be one of them. @collinjackson has a similar issue with his work. cc @abarth.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(it doesn't have to be now, but it should be really soon. Having Google-specific services in the Flutter repo gives a very mixed message about what Flutter is. We want to make sure other companies and developers understand that they are peers, not subordinate in any way.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Our plan is to put them in the main repo first to see what is needed, then move them to a separate repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you want to check this in

@collinjackson
Copy link
Contributor

LGTM once the sky_services dependency is fixed and tests pass

@mpcomplete mpcomplete force-pushed the gcm branch 3 times, most recently from ad61334 to c8f6344 Compare January 8, 2016 23:37
@Hixie Hixie added the waiting for PR to land (fixed) A fix is in flight label Jan 9, 2016
mpcomplete added a commit that referenced this pull request Jan 11, 2016
Adds Flutter GCM package
@mpcomplete mpcomplete merged commit 253d687 into master Jan 11, 2016
@mpcomplete mpcomplete deleted the gcm branch January 11, 2016 19:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants