Skip to content

[web] exclude bitrotten context_menu_action_test.dart from CanvasKit shard #93268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Nov 8, 2021

It seems this test has bitrotten while waiting for the bringup: true flag to be flipped. Temporarily adding it to the list of known failing tests to fix the red tree.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Nov 8, 2021
@google-cla google-cla bot added the cla: yes label Nov 8, 2021
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yjbanov
Copy link
Contributor Author

yjbanov commented Nov 8, 2021

Merging without waiting to unblock the tree.

@yjbanov yjbanov merged commit 5a123f9 into flutter:master Nov 8, 2021
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants