Skip to content

implemented TapUp within InkResponse and InkWell #93833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 9, 2022
Merged

implemented TapUp within InkResponse and InkWell #93833

merged 4 commits into from
Feb 9, 2022

Conversation

@gslender
Copy link
Contributor

@gslender gslender commented Nov 18, 2021

implemented the missing TapUp event within InkResponse and InkWell

Issue #93683 identified this as missing

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 18, 2021
@google-cla google-cla bot added the cla: yes label Nov 18, 2021
dkwingsmt
dkwingsmt reviewed Nov 18, 2021
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for nit documentation. Also needs a 2nd review.

@gslender @dkwingsmt
Update packages/flutter/lib/src/material/ink_well.dart
e39ba4b 
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
werainkhatri
werainkhatri requested changes Nov 27, 2021
View reviewed changes
Copy link
Member

@werainkhatri werainkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to create a new issue for this PR and add it to the description like Fixes #ISSUE_NUMBER.

@gslender @werainkhatri
Update packages/flutter/lib/src/material/ink_well.dart
245273a 
Co-authored-by: Viren Khatri <werainkhatri.work@gmail.com>
werainkhatri
werainkhatri approved these changes Nov 27, 2021
View reviewed changes
Copy link
Member

@werainkhatri werainkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution.

@gslender @werainkhatri
Update packages/flutter/lib/src/material/ink_well.dart
706eb97 
Co-authored-by: Viren Khatri <werainkhatri.work@gmail.com>
@The28AWG The28AWG mentioned this pull request Jan 2, 2022
Closed
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Feb 9, 2022

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@werainkhatri werainkhatri merged commit ae3f99c into flutter:master Feb 9, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ae3f99c implemented TapUp within InkResponse and InkWell (flutter/flu…
d2c5d0c 
…tter#93833)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ae3f99c implemented TapUp within InkResponse and InkWell (flutter/flu…
f7e5c53 
…tter#93833)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ae3f99c implemented TapUp within InkResponse and InkWell (flutter/flu…
448772f 
…tter#93833)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ae3f99c implemented TapUp within InkResponse and InkWell (flutter/flu…
7f08d59 
…tter#93833)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ae3f99c implemented TapUp within InkResponse and InkWell (flutter/flu…
dc27185 
…tter#93833)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ae3f99c implemented TapUp within InkResponse and InkWell (flutter/flu…
9363d16 
…tter#93833)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ae3f99c implemented TapUp within InkResponse and InkWell (flutter/flu…
5d91029 
…tter#93833)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ae3f99c implemented TapUp within InkResponse and InkWell (flutter/flu…
e88efb4 
…tter#93833)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ae3f99c implemented TapUp within InkResponse and InkWell (flutter/flu…
4158f4f 
…tter#93833)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ae3f99c implemented TapUp within InkResponse and InkWell (flutter/flu…
5d94407 
…tter#93833)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ae3f99c implemented TapUp within InkResponse and InkWell (flutter/flu…
3ee4289 
…tter#93833)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@gslender @dkwingsmt
@werainkhatri @clocksmith
implemented TapUp within InkResponse and InkWell (flutter#93833)
0417ac4 
* implemented TapUp within InkResponse and InkWell

* Update packages/flutter/lib/src/material/ink_well.dart

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>

* Update packages/flutter/lib/src/material/ink_well.dart

Co-authored-by: Viren Khatri <werainkhatri.work@gmail.com>

* Update packages/flutter/lib/src/material/ink_well.dart

Co-authored-by: Viren Khatri <werainkhatri.work@gmail.com>

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Viren Khatri <werainkhatri.work@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmt dkwingsmt dkwingsmt left review comments

@werainkhatri werainkhatri werainkhatri approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gslender @fluttergithubbot @dkwingsmt @werainkhatri @Hixie