-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented TapUp within InkResponse and InkWell #93833
implemented TapUp within InkResponse and InkWell #93833
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for nit documentation. Also needs a 2nd review.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need to create a new issue for this PR and add it to the description like Fixes #ISSUE_NUMBER.
Co-authored-by: Viren Khatri <werainkhatri.work@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your contribution.
Co-authored-by: Viren Khatri <werainkhatri.work@gmail.com>
This pull request is not suitable for automatic merging in its current state.
|
* implemented TapUp within InkResponse and InkWell * Update packages/flutter/lib/src/material/ink_well.dart Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com> * Update packages/flutter/lib/src/material/ink_well.dart Co-authored-by: Viren Khatri <werainkhatri.work@gmail.com> * Update packages/flutter/lib/src/material/ink_well.dart Co-authored-by: Viren Khatri <werainkhatri.work@gmail.com> Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com> Co-authored-by: Viren Khatri <werainkhatri.work@gmail.com>
implemented the missing TapUp event within InkResponse and InkWell
Issue #93683 identified this as missing
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.