Skip to content

RenderIndexedStack - Mark invisible children as offstage in debugDescribeProperties #96639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 8, 2022
Merged

RenderIndexedStack - Mark invisible children as offstage in debugDescribeProperties #96639

merged 4 commits into from
Feb 8, 2022

Conversation

@WasserEsser
Copy link
Contributor

@WasserEsser WasserEsser commented Jan 14, 2022 •
edited
Loading

RenderIndexedStack did not override debugDescribeProperties and thus all childrens were marked as onstage, resulting in the behaviour described in #96581.

Inspired by @Albert221, this fixes #96581.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jan 14, 2022
@WasserEsser WasserEsser changed the title Mark invisible children as offstage in debugDescribeProperties RenderIndexedStack - Mark invisible children as offstage in debugDescribeProperties Jan 14, 2022
@WasserEsser WasserEsser marked this pull request as ready for review January 14, 2022 02:58
jacob314
jacob314 reviewed Jan 14, 2022
View reviewed changes
jacob314
jacob314 reviewed Jan 14, 2022
View reviewed changes
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

jacob314
jacob314 reviewed Jan 18, 2022
View reviewed changes
jacob314
jacob314 approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jacob314
jacob314 reviewed Jan 26, 2022
View reviewed changes
jacob314
jacob314 approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

goderbauer
goderbauer approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Feb 7, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 36a8f0f into flutter:master Feb 8, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…
d0a8f37 
…ebugDescribeProperties (flutter/flutter#96639)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…
7e96664 
…ebugDescribeProperties (flutter/flutter#96639)
@WasserEsser WasserEsser deleted the b96581 branch February 8, 2022 00:47
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…
3eb86a7 
…ebugDescribeProperties (flutter/flutter#96639)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…
8ba71a1 
…ebugDescribeProperties (flutter/flutter#96639)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…
7253967 
…ebugDescribeProperties (flutter/flutter#96639)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…
c682b01 
…ebugDescribeProperties (flutter/flutter#96639)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…
5004368 
…ebugDescribeProperties (flutter/flutter#96639)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…
d176582 
…ebugDescribeProperties (flutter/flutter#96639)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…
2e330f4 
…ebugDescribeProperties (flutter/flutter#96639)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…
8c80cec 
…ebugDescribeProperties (flutter/flutter#96639)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…
0c5310c 
…ebugDescribeProperties (flutter/flutter#96639)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…
e75b99c 
…ebugDescribeProperties (flutter/flutter#96639)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…
55dfcf4 
…ebugDescribeProperties (flutter/flutter#96639)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…
00e1939 
…ebugDescribeProperties (flutter/flutter#96639)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…
6162c59 
…ebugDescribeProperties (flutter/flutter#96639)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…
475ce05 
…ebugDescribeProperties (flutter/flutter#96639)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…
01349df 
…ebugDescribeProperties (flutter/flutter#96639)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
36a8f0f RenderIndexedStack - Mark invisible children as offstage in d…
c7000d8 
…ebugDescribeProperties (flutter/flutter#96639)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@WasserEsser @clocksmith
RenderIndexedStack - Mark invisible children as offstage in debugDesc…
e8c7e20 
…ribeProperties (flutter#96639)
@danagbemava-nc danagbemava-nc mentioned this pull request Jun 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacob314 jacob314 jacob314 approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IndexedStack doesn't respect index in Flutter Inspector

4 participants

@WasserEsser @fluttergithubbot @jacob314 @goderbauer