-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include -isysroot -arch and -miphoneos-version-min when creating dummy module App.framework #97689
Conversation
…y module App.framework
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
checkFileExists(dummyAppFramework.path); | ||
final String? version = await minPhoneOSVersion(dummyAppFramework.path); | ||
if (version != '9.0') { | ||
throw TaskResult.failure('Minimum version set to $version, expected 9.0'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test correctly fails on master without the additional flag:
Task result:
{
"success": false,
"reason": "Minimum version set to null, expected 9.0"
}
test-exempt: is a test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…ing dummy module App.framework (flutter/flutter#97689)
…y module App.framework (flutter#97689)
These extra flags create a framework that can be recognized by CocoaPods, so it knows to embed App.framework later after Flutter creates it.
Add
otool
test, which is passing: https://ci.chromium.org/p/flutter/builders/try/Mac%20module_test_ios/11940Fixes flutter/samples#1004
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.