Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in type cast. #97778

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Fix error in type cast. #97778

merged 2 commits into from
Feb 4, 2022

Conversation

chingjun
Copy link
Contributor

@chingjun chingjun commented Feb 4, 2022 •
edited
Loading

Casting to List<String> is an error when the original list is List<dynamic>.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 4, 2022
christopherfujino
christopherfujino reviewed Feb 4, 2022
View reviewed changes
packages/flutter_tools/lib/src/device.dart
@@ -993,7 +993,7 @@ class DebuggingOptions {
debuggingEnabled: (json['debuggingEnabled'] as bool?)!,
startPaused: (json['startPaused'] as bool?)!,
dartFlags: (json['dartFlags'] as String?)!,
dartEntrypointArgs: ((json['dartEntrypointArgs'] as List<String>?)?.cast<String>())!,
dartEntrypointArgs: ((json['dartEntrypointArgs'] as List<dynamic>?)?.cast<String>())!,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused as to this fix:

Casting to List is an error when the original list is List.

even after this change, the object could still be a list. It doesn't seem like calling list.cast<T>() where list is already a List<T> does not seem to be an error. Also, the test you added still passes without this fix.

Copy link
Contributor Author

@chingjun chingjun Feb 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github removed everything between <> in my original comment, I meant to say "casting to List<String> is an error when the original list is List<dynamic>."

Updated the original description.

And I missed a step in the test, I've updated the test to convert it to JSON string, and parse the JSON into a Map<String, Object>, and then run DebuggingOptions.fromJson.

The object returned from json.decode is a List<dynamic>, and it is an error to cast that to List<String> directly. It should be casted by using (list as List<dynamic>).cast<String>()

PTAL, thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, ok, that makes sense now :)

christopherfujino
christopherfujino approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

@fluttergithubbot fluttergithubbot merged commit 26d1da4 into flutter:master Feb 4, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
7126646
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
6d440bf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
93d1297
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
3bbb57a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
28ddb2d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
46ff725
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
47e7e1b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
0b08f32
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
224180d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
00b38e5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
1aeaa2f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
1f5efa8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
4359cc8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
3886ec3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
25689f9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
e8ea5f1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
c83a663
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
02f56fb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
aec29c7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
aa8f095
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
e485bcc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
636ae68
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
0d6e821
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
fb24c9d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
26d1da4 Fix error in type cast. (flutter/flutter#97778)
1404f16
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@chingjun @clocksmith
Fix error in type cast. (flutter#97778)
74a56c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chingjun @fluttergithubbot @christopherfujino