Added Material Navigation_Drawer in material demo #340

Alabhya268 · 2020-10-08T11:49:29Z

Gallery side - #334

Let me know if any thing needs to be changed

google-cla · 2020-10-08T11:49:35Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Alabhya268 · 2020-10-08T12:00:00Z

@googlebot I signed it!

rami-a

Thanks for the contribution, this looks great!

Just a few small pieces of feedback :)

lib/demos/material/navigation_drawer.dart

lib/l10n/intl_en.arb

Co-authored-by: Rami <2364772+rami-a@users.noreply.github.com>

lib/demos/material/navigation_drawer.dart

clocksmith

This looks really good!

rami-a

Thanks so much for adding this! Looks good with just one last comment

lib/demos/material/navigation_drawer.dart

Alabhya268 · 2020-10-08T16:32:46Z

This looks really good!

Thanks @clocksmith

Alabhya268 · 2020-10-08T17:02:56Z

Thanks so much for adding this! Looks good with just one last comment
Thanks @rami-a , I've just added trailing favorite icon ,please have a look

rami-a

Looking great, sorry just a couple more small suggestions

rami-a · 2020-10-08T17:08:11Z

lib/demos/material/navigation_drawer.dart

+          title: Text(
+            localization.demoNavigationDrawerToPageOne,
+          ),
+          trailing: const Icon(Icons.favorite, color: Colors.red),


Nit: Add these as leading instead of trailing and remove the color and let them use the default color.

rami-a · 2020-10-08T17:09:28Z

lib/demos/material/navigation_drawer.dart

+          title: Text(
+            localization.demoNavigationDrawerToPageTwo,
+          ),
+          trailing: const Icon(Icons.favorite, color: Colors.red),


Nit: Make this one a different icon, something like Icons.comment

rami-a · 2020-10-08T17:35:00Z

lib/demos/material/navigation_drawer.dart

+          title: Text(
+            localization.demoNavigationDrawerToPageOne,
+          ),
+          leading: const Icon(Icons.favorite, color: Colors.red),


Sorry if this wasn't clear in my earlier comment but please also remove the hardcoded color here too, and then it should be good to submit once @clocksmith approves too.

Sorry i didn't notice it earlier, I'll fix it .

rami-a · 2020-10-08T18:48:11Z

Looks like there is a failing check due to the compiled app size:
https://github.com/flutter/gallery/pull/340/checks?check_run_id=1227443237

Could you please update this to 5000 just to be safe:
https://github.com/flutter/gallery/blob/master/integration_test/gallery_compile_test.dart#L11

rami-a · 2020-10-09T14:06:56Z

Looking into why the golden tests is failing. It seems unrelated to your change @Alabhya268 so please bear with us.

cc @perclasson

rami-a · 2020-10-09T14:21:06Z

Thanks for fixing that @perclasson and thanks again @Alabhya268 for your contribution!

Alabhya268 · 2020-10-12T02:39:13Z

Thanks for fixing that @perclasson and thanks again @Alabhya268 for your contribution!

Thanks @perclasson @rami-a your guidance and advice helped me through my first PR.

Added Material Navigation_Drawer in material demo

fec10fa

Alabhya268 marked this pull request as draft October 8, 2020 12:04

Alabhya268 marked this pull request as ready for review October 8, 2020 12:05

Alabhya268 marked this pull request as draft October 8, 2020 12:05

Formatted code_segment

be6f3db

Alabhya268 marked this pull request as ready for review October 8, 2020 12:53

rami-a reviewed Oct 8, 2020

View reviewed changes

Alabhya268 and others added 5 commits October 8, 2020 21:09

Update lib/l10n/intl_en.arb

4556ebf

Co-authored-by: Rami <2364772+rami-a@users.noreply.github.com>

Update lib/l10n/intl_en.arb

f3d6818

Co-authored-by: Rami <2364772+rami-a@users.noreply.github.com>

Added trailing comma and removed redundant code

0dbbe79

Removed redundand code and fixed minor issues

51c8128

Formatted code_segment.dart

1ef0c01

clocksmith reviewed Oct 8, 2020

View reviewed changes

lib/demos/material/navigation_drawer.dart Show resolved Hide resolved

formatted code

32f0a8d

clocksmith reviewed Oct 8, 2020

View reviewed changes

rami-a approved these changes Oct 8, 2020

View reviewed changes

lib/demos/material/navigation_drawer.dart Show resolved Hide resolved

Alabhya268 added 2 commits October 8, 2020 22:25

Added trailing icon

11c08d7

Updated and formatted code_segment

40f3b2d

Alabhya268 requested a review from rami-a October 8, 2020 17:03

Alabhya268 added 2 commits October 8, 2020 22:34

Removed redundant code

8270c13

formatted

f4ed514

rami-a approved these changes Oct 8, 2020

View reviewed changes

Alabhya268 added 2 commits October 8, 2020 22:46

Added icon and formatted code

45a3484

Made trailing icons leading

44750d0

Alabhya268 requested a review from clocksmith October 8, 2020 17:23

rami-a approved these changes Oct 8, 2020

View reviewed changes

Removed hard coded color

b04d6f0

clocksmith approved these changes Oct 8, 2020

View reviewed changes

Updated bundleSizeBenchmark

ede9868

Alabhya268 requested a review from rami-a October 9, 2020 14:00

Merge branch 'master' into master

22dd485

rami-a merged commit 8f84336 into flutter:master Oct 9, 2020

Alabhya268 mentioned this pull request Oct 9, 2020

Add Material Navigation Drawer to Material Section #334

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Material Navigation_Drawer in material demo #340

Added Material Navigation_Drawer in material demo #340

Alabhya268 commented Oct 8, 2020

google-cla bot commented Oct 8, 2020

Alabhya268 commented Oct 8, 2020

rami-a left a comment

clocksmith left a comment

rami-a left a comment

Alabhya268 commented Oct 8, 2020

Alabhya268 commented Oct 8, 2020

rami-a left a comment

rami-a Oct 8, 2020

Alabhya268 Oct 8, 2020

rami-a Oct 8, 2020

Alabhya268 Oct 8, 2020

rami-a Oct 8, 2020

Alabhya268 Oct 8, 2020

rami-a commented Oct 8, 2020

rami-a commented Oct 9, 2020

rami-a commented Oct 9, 2020

Alabhya268 commented Oct 12, 2020 •

edited

Loading

Added Material Navigation_Drawer in material demo #340

Added Material Navigation_Drawer in material demo #340

Conversation

Alabhya268 commented Oct 8, 2020

google-cla bot commented Oct 8, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Alabhya268 commented Oct 8, 2020

rami-a left a comment

Choose a reason for hiding this comment

clocksmith left a comment

Choose a reason for hiding this comment

rami-a left a comment

Choose a reason for hiding this comment

Alabhya268 commented Oct 8, 2020

Alabhya268 commented Oct 8, 2020

rami-a left a comment

Choose a reason for hiding this comment

rami-a Oct 8, 2020

Choose a reason for hiding this comment

Alabhya268 Oct 8, 2020

Choose a reason for hiding this comment

rami-a Oct 8, 2020

Choose a reason for hiding this comment

Alabhya268 Oct 8, 2020

Choose a reason for hiding this comment

rami-a Oct 8, 2020

Choose a reason for hiding this comment

Alabhya268 Oct 8, 2020

Choose a reason for hiding this comment

rami-a commented Oct 8, 2020

rami-a commented Oct 9, 2020

rami-a commented Oct 9, 2020

Alabhya268 commented Oct 12, 2020 • edited Loading

Alabhya268 commented Oct 12, 2020 •

edited

Loading