This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Added Navigation Rail demo to Material section #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please let me know if anything needs to be changed. |
|
@rami-a could you please have a look at this PR. |
rami-a
reviewed
Oct 12, 2020
There was a problem hiding this comment.
Thanks for another contribution @Alabhya268 ! Looks pretty good but could you address my feedback please :)
I've made necessary changes please have a look . |
rami-a
approved these changes
Oct 13, 2020
clocksmith
reviewed
Oct 13, 2020
| selectedIndex: _selectedIndex, | ||
| onDestinationSelected: (index) { | ||
| setState( | ||
| () { |
There was a problem hiding this comment.
nit: can this be moved up 1 line?
clocksmith
reviewed
Oct 13, 2020
| }, | ||
| ); | ||
| }, | ||
| labelType: NavigationRailLabelType.selected, |
There was a problem hiding this comment.
Good choice for this demo!
clocksmith
reviewed
Oct 13, 2020
rami-a
approved these changes
Oct 13, 2020
| children: [ | ||
| NavigationRail( | ||
| leading: FloatingActionButton( | ||
| child: const Icon(Icons.add), onPressed: () {}), |
There was a problem hiding this comment.
Nit: Add a trailing comma and reformat.
There was a problem hiding this comment.
also thanks for guiding me.
clocksmith
approved these changes
Oct 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gallery Side - Closes #190