This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Migrate SnackBar methods to ScaffoldMessenger #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami-a
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
LGTM, you'll have to run flutter pub run grinder update-code-segments to update the demo code snippets and get the CI to pass (see https://github.com/flutter/gallery#generating-highlighted-code-segments for more info).
|
Thanks for the review @rami-a :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc/ @perclasson and @rami-a contacts for https://github.com/flutter/tests/blob/master/registry/flutter_gallery.test
flutter/flutter#66504 introduced the ScaffoldMessenger widget, which allows for persistent SnackBars across Scaffolds, and easier management of asynchronous SnackBars. The original SnackBar methods in Scaffold are going to be deprecated. Test failures were identified in this repository in flutter/flutter#67947, so this PR is intended to migrate to the new API.
Full Migration Guide:
flutter/website#4527
References:
flutter/flutter#62921
flutter/flutter#57218