Added Cupertino Context Menu in cupertino demo section . #361
Conversation
Alabhya268
changed the title
|
@rami-a @clocksmith Please have a look at this PR . |
|
Could you please include a screenshot of the demo in action, thanks! |
Please have a look at these screenshots . |
|
@rami-a , I just noticed a bug . When app is in dark theme mode ,The text below the flutter icon is not showing up in context menu demo ,it should show the text as shown in above screenshots . |
| final galleryLocalizations = GalleryLocalizations.of(context); | ||
| return CupertinoPageScaffold( | ||
| navigationBar: CupertinoNavigationBar( | ||
| middle: Text(galleryLocalizations.demoCupertinoContextMenuTitle), |
There was a problem hiding this comment.
Add automaticallyImplyLeading: false so the back button doesn't appear
lib/l10n/intl_en.arb
Outdated
| "@demoCupertinoContextMenuSubtitle": { | ||
| "description": "Subtitle for the cupertino context menu component demo." | ||
| }, | ||
| "demoCupertinoContextMenuDescription": "A full-screen modal route that opens when the child is long-pressed. When open, the CupertinoContextMenu shows the child, or the widget returned by previewBuilder if given, in a large full-screen Overlay with a list of buttons specified by actions.", |
There was a problem hiding this comment.
Simplify this description a bit . Something like:
"An iOS-style full screen contextual menu that appears when an element is long-pressed."
There was a problem hiding this comment.
I've replaced it with this one .
Hmm, this is odd, but should be fixable |
| final galleryLocalizations = GalleryLocalizations.of(context); | ||
| return CupertinoPageScaffold( | ||
| navigationBar: CupertinoNavigationBar( | ||
| middle: Text(galleryLocalizations.demoCupertinoContextMenuTitle), |
There was a problem hiding this comment.
Add a trailing comma to format nicer
|
Yes, feel free to manually hard code the text color to black here. Additionally, could you center align the text. Then it should be good to merge, thanks! |
| child: Container( | ||
| child: const FlutterLogo(size: 250), | ||
| ), | ||
| actions: <Widget>[ |
Co-authored-by: Rami <2364772+rami-a@users.noreply.github.com>
Is it ok or anything needs to be changed ?