Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Scope SnackBars for nested Scaffolds in demo #377

Merged
merged 6 commits into from
Nov 21, 2020
Merged

Scope SnackBars for nested Scaffolds in demo #377

merged 6 commits into from
Nov 21, 2020

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Nov 18, 2020

Fixes #376

@Piinks Piinks requested a review from rami-a November 18, 2020 00:09
@Piinks Piinks mentioned this pull request Nov 18, 2020
Closed
rami-a
rami-a approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@rami-a rami-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix Kate!

Though I believe there are a few more of these demos that also show a snackbar, they'd probably have to be updated too (dialog_demo, menu_demo, etc.)

@Piinks
Copy link
Contributor Author

Piinks commented Nov 18, 2020

Ah! thank you! I will run through and check all of them. :)

@Piinks
Copy link
Contributor Author

Piinks commented Nov 20, 2020

Found a much cleaner fix across the board. :) All SnackBars are properly scoped now.

@Piinks Piinks merged commit 67bab78 into flutter:master Nov 21, 2020
@guidezpl guidezpl mentioned this pull request Jul 13, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rami-a rami-a rami-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snackbar not working as expected
2 participants
@Piinks @rami-a