This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[State Restoration] Restorable Material Code Samples - Part 3/3 #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
rami-a
approved these changes
Dec 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple comments
@@ -8,8 +8,8 @@ import 'package:flutter/cupertino.dart'; | |||
|
|||
// BEGIN navDrawerDemo | |||
|
|||
// Pressing the Navigation Drawer button the left of Appbar to show | |||
// a simple Drawer with Two items. | |||
// Pressing the Navigation Drawer button the left of AppBar to show |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// Pressing the Navigation Drawer button the left of AppBar to show | |
// Press the Navigation Drawer button to the left of AppBar to show |
lib/demos/material/tabs_demo.dart
Outdated
final RestorableInt tabIndex = RestorableInt(0); | ||
|
||
@override | ||
String get restorationId => 'tab_non_scrollable_demo'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
String get restorationId => 'tab_non_scrollable_demo'; | |
String get restorationId => 'tab_scrollable_demo'; |
shihaohong
changed the title
Restorable Material Code Samples - Part 3/?
Restorable Material Code Samples - Part 3/3
Dec 16, 2020
shihaohong
changed the title
Restorable Material Code Samples - Part 3/3
[State Restoration] Restorable Material Code Samples - Part 3/3
Feb 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More State Restoration Demos:
Todos