Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

[State Restoration] Restorable Material Code Samples - Part 3/3 #382

Merged
merged 13 commits into from
Dec 6, 2020

Conversation

shihaohong
Copy link

Description

More State Restoration Demos:

  • Navigation Rail
  • RadioDemo and SwitchDemo
  • Slider Demos
  • Tabs Demos

Todos

  • State Restorable TextFormFields
  • RestorableBoolN implementation for Checkbox demo

Copy link
Contributor

@rami-a rami-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple comments

@@ -8,8 +8,8 @@ import 'package:flutter/cupertino.dart';

// BEGIN navDrawerDemo

// Pressing the Navigation Drawer button the left of Appbar to show
// a simple Drawer with Two items.
// Pressing the Navigation Drawer button the left of AppBar to show
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Pressing the Navigation Drawer button the left of AppBar to show
// Press the Navigation Drawer button to the left of AppBar to show

final RestorableInt tabIndex = RestorableInt(0);

@override
String get restorationId => 'tab_non_scrollable_demo';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
String get restorationId => 'tab_non_scrollable_demo';
String get restorationId => 'tab_scrollable_demo';

@shihaohong shihaohong merged commit 86b2ac2 into flutter:master Dec 6, 2020
@shihaohong shihaohong deleted the more-demos-pt2 branch December 6, 2020 13:57
@shihaohong shihaohong changed the title Restorable Material Code Samples - Part 3/? Restorable Material Code Samples - Part 3/3 Dec 16, 2020
@shihaohong shihaohong changed the title Restorable Material Code Samples - Part 3/3 [State Restoration] Restorable Material Code Samples - Part 3/3 Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants