Use new macOS build system #397
Conversation
| @@ -15,7 +15,7 @@ | |||
| <BuildableReference | |||
| BuildableIdentifier = "primary" | |||
| BlueprintIdentifier = "33CC10EC2044A3C60003C045" | |||
| BuildableName = "Flutter Gallery.app" | |||
| BuildableName = "gallery.app" | |||
There was a problem hiding this comment.
When built, the app is named Flutter Gallery.app, per macos/Flutter/ephemeral/.app_filename and macos/Runner/Configs/AppInfo.xcconfig's PRODUCT_NAME. Should this also be?
There was a problem hiding this comment.
Do you know where the Flutter Gallery -> gallery change came from? When I flutter build macos it updated the project file in the same way, but doesn't touch the buildable name, which is set
Did you regenerate this file? It shouldn't have changed...
There was a problem hiding this comment.
I tried to reproduce and it fixed itself, my favorite kind of issue. Changing the PRODUCT_NAME correctly propagated to Runner.xcheme.
| @@ -204,7 +193,7 @@ | |||
| ); | |||
| name = Runner; | |||
| productName = Runner; | |||
| productReference = 33CC10ED2044A3C60003C045 /* Flutter Gallery.app */; | |||
| productReference = 33CC10ED2044A3C60003C045 /* gallery.app */; | |||
There was a problem hiding this comment.
Should comments use macos/Flutter/ephemeral/.app_filename/macos/Runner/Configs/AppInfo.xcconfig's PRODUCT_NAME?
There was a problem hiding this comment.
No, I think in the comments Xcode actually hydrates the build settings, it thinks the name of the product is gallery.app.
| @@ -13,7 +13,7 @@ | |||
| </customObject> | |||
| <customObject id="-1" userLabel="First Responder" customClass="FirstResponder"/> | |||
| <customObject id="-3" userLabel="Application" customClass="NSObject"/> | |||
| <customObject id="Voe-Tx-rLC" customClass="AppDelegate" customModule="Flutter_Gallery" customModuleProvider="target"> | |||
| <customObject id="Voe-Tx-rLC" customClass="AppDelegate" customModule="Runner" customModuleProvider="target"> | |||
There was a problem hiding this comment.
Did you mean to change this file? I don't know why the customModule changed from Flutter_Gallery to Runner or why the fullSizeContentView window style mask was removed.
Did you regenerate it, or did Xcode decide to touch the file when you opened it?
There was a problem hiding this comment.
This was a regeneration. I think we modified both at some point in the past so this seems fine
| end | ||
|
|
||
| require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelper'), flutter_root) |
There was a problem hiding this comment.
What version of Flutter does the gallery need to run against? This will fail on anything less than flutter/flutter#72020 which is only in master.
There was a problem hiding this comment.
Right, it runs against master
All generated from
flutter create .and a run, except for the window size, app icons, and PRODUCT_NAME.Also remove extra web favicon