Defer load demos #423
Defer load demos #423
Conversation
| @@ -86,7 +86,7 @@ class HomePage extends StatelessWidget { | |||
| package: 'flutter_gallery_assets', | |||
| ), | |||
| assetDarkColor: const Color(0xFF253538), | |||
| studyRoute: RallyApp.loginRoute, | |||
| studyRoute: rally_routes.loginRoute, | |||
There was a problem hiding this comment.
Is there a reason why the Shrine and StarterApp routes aren't changed to do the same as the other studies?
lib/pages/home.dart
Outdated
| @@ -1118,6 +1118,41 @@ double _carouselHeight(double scaleFactor, BuildContext context) => math.max( | |||
| scaleFactor, | |||
| _carouselHeightMin); | |||
|
|
|||
| typedef LibraryLoader = Future<void> Function(); | |||
There was a problem hiding this comment.
It might make more sense for the LibraryLoader and DeferredWidget to be moved into its own dart file
There was a problem hiding this comment.
thx for suggestion. Moved to deferred_widget.dart
lib/studies/crane/routes.dart
Outdated
| @@ -0,0 +1 @@ | |||
| const String defaultRoute = '/crane'; | |||
There was a problem hiding this comment.
Nit: needs new line at end of file
lib/studies/fortnightly/routes.dart
Outdated
| @@ -0,0 +1 @@ | |||
| const String defaultRoute = '/fortnightly'; | |||
There was a problem hiding this comment.
Nit: needs new line at end of file
| @@ -0,0 +1,2 @@ | |||
| const String loginRoute = '/rally/login'; | |||
There was a problem hiding this comment.
Should the route consts for all the studies just be in one file instead of multiple?
There was a problem hiding this comment.
Torn on this one. I like that they are pretty independent. the demo types are breaking that right now, maybe those should be split too.
| @@ -0,0 +1,2 @@ | |||
| const String loginRoute = '/shrine/login'; | |||
There was a problem hiding this comment.
Looks like this file is missing copyright header
| @@ -86,7 +86,7 @@ class HomePage extends StatelessWidget { | |||
| package: 'flutter_gallery_assets', | |||
| ), | |||
| assetDarkColor: const Color(0xFF253538), | |||
| studyRoute: RallyApp.loginRoute, | |||
There was a problem hiding this comment.
It looks like the Shrine and Starter app are not using the new routes files you added yet
This drops release binary size from 4,936,531 to 4,125,088.