This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
[Material] Added focusnodes in textfield demo #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami-a
approved these changes
Feb 5, 2021
| _lifeStory = FocusNode(); | ||
| _password = FocusNode(); | ||
| _retypePassword = FocusNode(); | ||
| super.initState(); |
There was a problem hiding this comment.
Please call super first for initState(), it is fine to call last for dispose()
|
I've made changes needed. |
|
@rami-a , Should I also add focusnode in shrine and rally login form, If so do I do it in a separate PR or in this one? Let me know what you think. |
Sure that's a good idea! I'd say make it a separate PR. Thanks! |
|
Hey @Alabhya268, I have now fixed the broken tests. Please update your branch with the latest changes from master when you get a chance and then it should be good to merge! |
|
Looks like after merging your divider PR, this one needs to be updated again |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #422
@rami-a, I've added focusnodes, Please review this PR.
WhatsApp.Video.2021-02-05.at.9.34.25.PM.mp4