Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

[Reply] Cap body at 1340 for desktop and tablet #425

Merged
merged 8 commits into from
Feb 18, 2021
Merged

[Reply] Cap body at 1340 for desktop and tablet #425

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
15524fc
Cap reply body with to 1340 on desktop/tablet
Renzo-Olivares Feb 8, 2021
1d8f2fe
Fix white lines around body of navigation rail
Renzo-Olivares Feb 8, 2021
728f3eb
Cap tablet width to 800
Renzo-Olivares Feb 8, 2021
bee3a0e
Merge branch 'master' of github.com:flutter/gallery into reply_body_cap
Renzo-Olivares Feb 10, 2021
93c0188
Use Center widget instead of Row and Flexible
Renzo-Olivares Feb 10, 2021
408077c
Change divider width back to 1 and set cap at 1340 for both tablet an…
Renzo-Olivares Feb 11, 2021
c8797ff
Merge branch 'master' into reply_body_cap
guidezpl Feb 18, 2021
ece2048
Merge branch 'master' into reply_body_cap
guidezpl Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lib/studies/reply/adaptive_nav.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,11 +241,17 @@ class _DesktopNavState extends State<_DesktopNav>
);
},
),
const VerticalDivider(thickness: 1, width: 1),
const VerticalDivider(thickness: 1, width: 2),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the reason for this change?

Copy link
Contributor Author

@Renzo-Olivares Renzo-Olivares Feb 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

white_lines

I increased the width to remedy some artifacts (white vertical lines surrounding body shown above). From my observation, they seem to be a result of the navigation rail body not expanding to its max-width like it previously did before this change.

Copy link
Contributor Author

@Renzo-Olivares Renzo-Olivares Feb 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these lines still show up if I don't have my browser window maximized. It looks like they show up right when I stretch the body past the 1340 width cap. Maybe because the Expanded widget is no longer taking up the entire available space, so there is a gap. I'll keep working on this.

Expanded(
child: _SharedAxisTransitionSwitcher(
defaultChild: _MailNavigator(
child: MailboxBody(key: widget.inboxKey),
child: Center(
child: ConstrainedBox(
constraints:
BoxConstraints(maxWidth: widget.extended ? 1340 : 800),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original bug was to cap at only 1340. Why 800 for non extended?

Copy link
Contributor Author

@Renzo-Olivares Renzo-Olivares Feb 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're right. I misunderstood the purpose of the cap and made it consistent for both desktop and tablet. I changed it back to match the original issue, also the margins were not constant when the width was under 1340 with the added 800 cap.

child: _SharedAxisTransitionSwitcher(
defaultChild: _MailNavigator(
child: MailboxBody(key: widget.inboxKey),
),
),
),
),
),
Expand Down