Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Roll path_provider to a version compatible with the latest Dart SDK #436

Merged

Conversation

jason-simmons
Copy link
Member

No description provided.

pubspec.yaml Outdated
@@ -37,6 +37,7 @@ dev_dependencies:
args: ^2.0.0
grinder: ^0.9.0-nullsafety.0
path: ^1.8.0
path_provider: ^2.0.0-nullsafety.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting this to be a dependency override. Why is it a dev_dependency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this to an override

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ explanation of why a dev_dependency rather than a dependency override.

@jason-simmons jason-simmons merged commit e2cfe22 into flutter:master Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants