This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Revert "[Reply] Cap body at 1340 for desktop and tablet" #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cb10d4a.
|
I'm not exactly sure what's happening, but it seems like the golden tests are failing even when they are updated (See #409, another PR where the golden tests fail even when they are being updated). Was there a recent change to the golden generation logic or the golden testing that could be causing some kind of indeterminism? |
Renzo-Olivares
force-pushed
the
revert-425-reply_body_cap
branch
from
cdf6275
to
0bdc7f6
Compare
|
Closing this in favor of #445 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #425
The change being reverted still had issues regarding artifacts. See picture below. White lines surrounding the MailBody. These lines only show up when expanding the body past the 1340 cap.