Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Fix UNUSED_ELEMENT_PARAMETER for unused field formal initializers. #585

Merged
merged 3 commits into from
Jan 14, 2022

Conversation

scheglov
Copy link
Contributor

@scheglov scheglov commented Jan 14, 2022

We would like to land https://dart-review.googlesource.com/c/sdk/+/226962 into Dart analyzer and fixing exiting violations.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@scheglov scheglov requested a review from guidezpl January 14, 2022 01:42
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests can be fixed with flutter pub run grinder update-code-segments

@scheglov scheglov merged commit bd26b8f into flutter:master Jan 14, 2022
@scheglov scheglov deleted the fix-UNUSED_ELEMENT_PARAMETER branch January 14, 2022 19:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants