This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the recently released
web_benchmarks: 0.0.7
that supports Chrome 89+ to reenable the web benchmarks here.There was also a problem in the
gallery_automator.dart
file, that useddart:io
to print output tostdout
.dart:io
methods cannot be called in a browser, and the benchmarks failed.I removed the dependency on dart:io from that file, and replaced
stdout.writeln
byprint
calls. I had toignore_for_file:avoid_print
because the analyzer thinks that the code I'm touching is "production", when it should be detected as tests.This is what I get when I run the benchmarks in my machine (looks good, but I need to run each of the tests separately. If I do
flutter test test_benchmarks
, there seems to be some race condition that makes the benchmarks to never finish (?):PS: I think this PR should be text-exempt, since it's reenabling a bunch of benchmarks.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.