Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Make Shrine shopping cart icons display correctly #651

Merged
merged 8 commits into from
Apr 25, 2022

Conversation

pennzht
Copy link
Member

@pennzht pennzht commented Apr 22, 2022

Fixes the issue where shopping cart icons cannot be displayed.

Fixes #650

shrine-new

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
    • This is a bug fix; no documentation needed.
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@pennzht pennzht marked this pull request as ready for review April 25, 2022 13:49
@pennzht pennzht requested a review from guidezpl April 25, 2022 13:49
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|
                        

Nice!

@pennzht pennzht merged commit e1d6d7e into flutter:master Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sample app "shrine" example shopping cart display isnt done
2 participants