This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
use super parameters #684
Merged
use super parameters #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanv8060
commented
May 13, 2022
| @@ -27,3 +27,4 @@ linter: | |||
| - unawaited_futures | |||
| - unnecessary_statements | |||
| - unsafe_html | |||
| - use_super_parameters | |||
There was a problem hiding this comment.
should I add this line?
There was a problem hiding this comment.
I think so, since it's not part of flutter_lints
| import 'package:gallery/demos/material/material_demo_types.dart'; | ||
|
|
||
| class DividerDemo extends StatelessWidget { | ||
| const DividerDemo({super.key, required this.type}); |
There was a problem hiding this comment.
CRLF issue, this is the only change in this file. or should I revert the change in this file to try again?
| @@ -192,10 +188,7 @@ class _SectionedMenuDemo extends StatelessWidget { | |||
| // a menu whose current value is highlighted and aligned over the | |||
| // list item's center line. | |||
| class _SimpleMenuDemo extends StatefulWidget { | |||
| const _SimpleMenuDemo({ | |||
| Key? key, | |||
There was a problem hiding this comment.
this has been removed from private classes which were not providing keys, due to unused element lint. Although they are actually not being used, I am not sure if this is the style.
guidezpl
approved these changes
May 16, 2022
| @@ -27,3 +27,4 @@ linter: | |||
| - unawaited_futures | |||
| - unnecessary_statements | |||
| - unsafe_html | |||
| - use_super_parameters | |||
There was a problem hiding this comment.
I think so, since it's not part of flutter_lints
| import 'package:gallery/demos/material/material_demo_types.dart'; | ||
|
|
||
| class DividerDemo extends StatelessWidget { | ||
| const DividerDemo({super.key, required this.type}); |
| @@ -192,10 +188,7 @@ class _SectionedMenuDemo extends StatelessWidget { | |||
| // a menu whose current value is highlighted and aligned over the | |||
| // list item's center line. | |||
| class _SimpleMenuDemo extends StatefulWidget { | |||
| const _SimpleMenuDemo({ | |||
| Key? key, | |||
|
Unlike #608 (comment) code viewer worked perfectly fine this time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use super parameters
fixes #631
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.