Delete Chrome temp cache after closing (#119062)

* Delete Chrome temp cache after closeing * Update packages/flutter_tools/lib/src/web/chrome.dart Co-authored-by: Christopher Fujino <fujino@google.com> --------- Co-authored-by: Christopher Fujino <fujino@google.com>
flutter · Feb 10, 2023 · 25c2c22 · 25c2c22
1 parent 298c874
commit 25c2c22
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/packages/flutter_tools/lib/src/web/chrome.dart b/packages/flutter_tools/lib/src/web/chrome.dart
@@ -222,6 +222,12 @@ class ChromiumLauncher {
     if (process != null && cacheDir != null) {
       unawaited(process.exitCode.whenComplete(() {
         _cacheUserSessionInformation(userDataDir, cacheDir);
+        // cleanup temp dir
+        try {
+          userDataDir.deleteSync(recursive: true);
+        } on FileSystemException {
+          // ignore
+        }
       }));
     }
     return connect(Chromium(

diff --git a/packages/flutter_tools/test/web.shard/chrome_test.dart b/packages/flutter_tools/test/web.shard/chrome_test.dart
@@ -419,13 +419,6 @@ void main() {
       cacheDir: dataDir,
     );
 
-    exitCompleter.complete();
-    await Future<void>.delayed(const Duration(milliseconds: 1));
-
-    // writes non-crash back to dart_tool
-    expect(preferencesFile.readAsStringSync(), '"exit_type":"Normal"');
-
-
     // validate any Default content is copied
     final Directory defaultContentDir = fileSystem
         .directory('.tmp_rand0/flutter_tools_chrome_device.rand0')
@@ -434,13 +427,22 @@ void main() {
 
     expect(defaultContentDir, exists);
 
+    exitCompleter.complete();
+    await Future<void>.delayed(const Duration(milliseconds: 1));
+
+    // writes non-crash back to dart_tool
+    expect(preferencesFile.readAsStringSync(), '"exit_type":"Normal"');
+
     // Validate cache dirs are not copied.
     for (final String cache in kCodeCache) {
       expect(fileSystem
         .directory('.tmp_rand0/flutter_tools_chrome_device.rand0')
         .childDirectory('Default')
         .childDirectory(cache), isNot(exists));
     }
+
+    // validate defaultContentDir is deleted after exit, data is in cache
+    expect(defaultContentDir, isNot(exists));
   });
 
   testWithoutContext('can retry launch when glibc bug happens', () async {