Skip to content

Commit

Permalink
[go_router] Remove unused navigator keys (#3708)
Browse files Browse the repository at this point in the history
Remove unused navigator keys from GoRouteData and ShellRouteData.
Closes flutter/flutter#124497
  • Loading branch information
GP4cK authored Apr 28, 2023
1 parent d155228 commit 5bc70c7
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
6 changes: 5 additions & 1 deletion packages/go_router/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 6.5.9

- Removes navigator keys from `GoRouteData` and `ShellRouteData`.

## 6.5.8

- Adds name parameter to `TypedGoRoute`
Expand All @@ -16,7 +20,7 @@

## 6.5.4

- Remove navigator keys from `TypedGoRoute` and `TypedShellRoute`.
- Removes navigator keys from `TypedGoRoute` and `TypedShellRoute`.

## 6.5.3

Expand Down
8 changes: 0 additions & 8 deletions packages/go_router/lib/src/route_data.dart
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,6 @@ abstract class GoRouteData extends RouteData {
static final Expando<GoRouteData> _stateObjectExpando = Expando<GoRouteData>(
'GoRouteState to GoRouteData expando',
);

/// [navigatorKey] is used to point to a certain navigator
///
/// It will use the given key to find the right navigator for [GoRoute]
GlobalKey<NavigatorState>? get navigatorKey => null;
}

/// Base class for supporting
Expand Down Expand Up @@ -208,9 +203,6 @@ abstract class ShellRouteData extends RouteData {
Expando<ShellRouteData>(
'GoRouteState to ShellRouteData expando',
);

/// It will be used to instantiate [Navigator] with the given key
GlobalKey<NavigatorState>? get navigatorKey => null;
}

/// A superclass for each typed route descendant
Expand Down
2 changes: 1 addition & 1 deletion packages/go_router/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: go_router
description: A declarative router for Flutter based on Navigation 2 supporting
deep linking, data-driven routes and more
version: 6.5.8
version: 6.5.9
repository: https://github.com/flutter/packages/tree/main/packages/go_router
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router%22

Expand Down

0 comments on commit 5bc70c7

Please sign in to comment.