Update local_auth_darwin CODEOWNERS #10074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds @okorohelijah as a code owner for the local_auth_darwin package. The change is functionally correct, but I have a suggestion to improve maintainability by sorting the code owners alphabetically. Additionally, please note that the pull request title does not follow the repository's contribution guidelines. The title should be updated to start with the package name in square brackets, for example: [local_auth_darwin] Update CODEOWNERS.
| packages/image_picker/image_picker_macos/** @vashworth @louisehsu | ||
| packages/in_app_purchase/in_app_purchase_storekit/** @louisehsu @LongCatIsLooong | ||
| packages/local_auth/local_auth_darwin/** @vashworth | ||
| packages/local_auth/local_auth_darwin/** @vashworth @okorohelijah |
There was a problem hiding this comment.
For better maintainability and consistency, it's good practice to sort code owners alphabetically.
packages/local_auth/local_auth_darwin/** @okorohelijah @vashworth
Member
Author
There was a problem hiding this comment.
Sorting by unofficial "primary" and "secondary" even though the tooling doesn't enforce it.
jmagman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 26, 2025
flutter/packages@117bf63...389c678 2025-09-25 magder@google.com Update local_auth_darwin CODEOWNERS (flutter/packages#10074) 2025-09-25 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for time offsets of ad breaks (flutter/packages#9953) 2025-09-25 engine-flutter-autoroll@skia.org Roll Flutter from 4a04204 to b1a28bc (44 revisions) (flutter/packages#10077) 2025-09-24 jason-simmons@users.noreply.github.com [google_fonts] Make a map keyed on FontWeight non-const (flutter/packages#10058) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add @okorohelijah to CODEOWNERs.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3