-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[espresso] updates build files to use JVM 17 #10162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,11 +3,11 @@ description: Java classes for testing Flutter apps using Espresso. | |
Allows driving Flutter widgets from a native Espresso test. | ||
repository: https://github.com/flutter/packages/tree/main/packages/espresso | ||
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+espresso%22 | ||
version: 0.4.0+14 | ||
version: 0.4.0+15 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bumping the minimum required Flutter version is a breaking change according to the pub versioning philosophy.1 For a pre-1.0.0 package, this should be reflected as a minor version bump. Please consider changing the version to version: 0.5.0 Style Guide ReferencesFootnotes
|
||
|
||
environment: | ||
sdk: ^3.7.0 | ||
flutter: ">=3.29.0" | ||
sdk: ^3.9.0 | ||
flutter: ">=3.35.0" | ||
|
||
flutter: | ||
plugin: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the pub versioning philosophy, increasing the minimum Flutter SDK version is a breaking change.1 For a package with a version less than 1.0.0, this should be a minor version bump. Please update the version to
0.5.0
.Style Guide References
Footnotes
The style guide states that bumping the minimum Flutter version is a breaking change, which requires a major version increment (or minor for pre-1.0.0 packages). ↩
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, Jan.