Fix Namespace Assignment Test #10289
Merged
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a test for validating Gradle namespace declarations. The original test was not properly asserting the expected error condition. Your changes introduce the correct error handling and assertions, making the test suite more robust. I've included one minor suggestion to improve the readability of a test description string.
| }); | ||
|
|
||
| test('fails when namespace is declared without "=" declaration', () async { | ||
| test('fails when namespace is declared without \"=\" declaration', () async { |
There was a problem hiding this comment.
The test description string contains \"=\", which in a single-quoted string results in a literal backslash being included in the test name (e.g., ... \=" ...). This is likely unintentional. For clarity, it's better to either use correct quoting (like the original version) or rephrase the description to avoid quoting characters altogether.
Suggested change
| test('fails when namespace is declared without \"=\" declaration', () async { | |
| test('fails when namespace is declared without an assignment operator', () async { |
mboetger
approved these changes
Oct 24, 2025
jesswrd
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 28, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 28, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 28, 2025
flutter/packages@bbf96a0...c8ba0cc 2025-10-27 jessiewong401@gmail.com Fix Namespace Assignment Test (flutter/packages#10289) 2025-10-27 nateshmbhat1@gmail.com [video_player] Add audio track management support to platform interface (flutter/packages#10171) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
walley892
pushed a commit
to walley892/flutter
that referenced
this pull request
Oct 30, 2025
…r#177672) flutter/packages@bbf96a0...c8ba0cc 2025-10-27 jessiewong401@gmail.com Fix Namespace Assignment Test (flutter/packages#10289) 2025-10-27 nateshmbhat1@gmail.com [video_player] Add audio track management support to platform interface (flutter/packages#10171) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a namespace is declared without a "=" assignment, there should be an error. I think the test did not check that the ouput contains an error. Noticed this because I saw an extra stack trace when running a test.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3