Skip to content

[image_picker] Remove use of Pigeon's Dart test generator #10320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+348 −2,028
Open

[image_picker] Remove use of Pigeon's Dart test generator #10320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5d7031b
Remove cruft from Android
stuartmorgan-g Oct 28, 2025
b16517d
Switch iOS, still using legacy test logger
stuartmorgan-g Oct 28, 2025
c4b752b
Refactor and improve testing
stuartmorgan-g Oct 29, 2025
2c39596
Remove incorrect auto-added assertions
stuartmorgan-g Oct 29, 2025
46fa2af
Autoforamt
stuartmorgan-g Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/image_picker/image_picker_android/pigeons/messages.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import 'package:pigeon/pigeon.dart';
@ConfigurePigeon(
PigeonOptions(
dartOut: 'lib/src/messages.g.dart',
dartTestOut: 'test/test_api.g.dart',
javaOut:
'android/src/main/java/io/flutter/plugins/imagepicker/Messages.java',
javaOptions: JavaOptions(package: 'io.flutter.plugins.imagepicker'),
Expand Down Expand Up @@ -94,7 +93,7 @@ class CacheRetrievalResult {
final List<String> paths;
}

@HostApi(dartHostTestHandler: 'TestHostImagePickerApi')
@HostApi()
abstract class ImagePickerApi {
/// Selects images and returns their paths.
@TaskQueue(type: TaskQueueType.serialBackgroundThread)
Expand Down
313 changes: 0 additions & 313 deletions packages/image_picker/image_picker_android/test/test_api.g.dart
View file
Open in desktop

This file was deleted.

7 changes: 6 additions & 1 deletion packages/image_picker/image_picker_ios/lib/image_picker_ios.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// found in the LICENSE file.
import 'dart:async';

import 'package:flutter/foundation.dart' show visibleForTesting;
import 'package:image_picker_platform_interface/image_picker_platform_interface.dart';

import 'src/messages.g.dart';
Expand Down Expand Up @@ -43,7 +44,11 @@ SourceCamera _convertCamera(CameraDevice camera) {

/// An implementation of [ImagePickerPlatform] for iOS.
class ImagePickerIOS extends ImagePickerPlatform {
final ImagePickerApi _hostApi = ImagePickerApi();
/// Creates a new plugin implementation instance.
ImagePickerIOS({@visibleForTesting ImagePickerApi? api})
: _hostApi = api ?? ImagePickerApi();

final ImagePickerApi _hostApi;

/// Registers this class as the default platform implementation.
static void registerWith() {
Expand Down
3 changes: 1 addition & 2 deletions packages/image_picker/image_picker_ios/pigeons/messages.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import 'package:pigeon/pigeon.dart';
@ConfigurePigeon(
PigeonOptions(
dartOut: 'lib/src/messages.g.dart',
dartTestOut: 'test/test_api.g.dart',
objcHeaderOut:
'ios/image_picker_ios/Sources/image_picker_ios/include/image_picker_ios/messages.g.h',
objcSourceOut: 'ios/image_picker_ios/Sources/image_picker_ios/messages.g.m',
Expand Down Expand Up @@ -52,7 +51,7 @@ class SourceSpecification {
SourceCamera camera;
}

@HostApi(dartHostTestHandler: 'TestHostImagePickerApi')
@HostApi()
abstract class ImagePickerApi {
@async
@ObjCSelector('pickImageWithSource:maxSize:quality:fullMetadata:')
Expand Down
Loading