Skip to content

[path_provider] Remove use of Pigeon's Dart test generator #10323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[path_provider] Remove use of Pigeon's Dart test generator #10323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/path_provider/path_provider_android/lib/path_provider_android.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter/foundation.dart' show visibleForTesting;
import 'package:path_provider_platform_interface/path_provider_platform_interface.dart';
import 'messages.g.dart' as messages;

Expand Down Expand Up @@ -36,7 +37,11 @@ messages.StorageDirectory _convertStorageDirectory(

/// The Android implementation of [PathProviderPlatform].
class PathProviderAndroid extends PathProviderPlatform {
final messages.PathProviderApi _api = messages.PathProviderApi();
/// Creates an instance of [PathProviderAndroid].
PathProviderAndroid({@visibleForTesting messages.PathProviderApi? api})
: _api = api ?? messages.PathProviderApi();

final messages.PathProviderApi _api;

/// Registers this class as the default instance of [PathProviderPlatform].
static void registerWith() {
Expand Down
3 changes: 1 addition & 2 deletions packages/path_provider/path_provider_android/pigeons/messages.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import 'package:pigeon/pigeon.dart';
package: 'io.flutter.plugins.pathprovider',
),
dartOut: 'lib/messages.g.dart',
dartTestOut: 'test/messages_test.g.dart',
copyrightHeader: 'pigeons/copyright.txt',
),
)
Expand All @@ -31,7 +30,7 @@ enum StorageDirectory {
documents,
}

@HostApi(dartHostTestHandler: 'TestPathProviderApi')
@HostApi()
abstract class PathProviderApi {
@TaskQueue(type: TaskQueueType.serialBackgroundThread)
String? getTemporaryPath();
Expand Down
301 changes: 0 additions & 301 deletions packages/path_provider/path_provider_android/test/messages_test.g.dart
View file
Open in desktop

This file was deleted.

Loading