Skip to content

[in_app_purchase_storekit] Fix Xcode 26.2 analyzer warnings #10649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Dec 19, 2025
Merged

[in_app_purchase_storekit] Fix Xcode 26.2 analyzer warnings #10649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/in_app_purchase/in_app_purchase_storekit/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## NEXT

* Fixes Xcode 26.2 analyzer warnings in example app tests.

## 0.4.7

* Adds `SK2Transaction.unfinishedTransactions()` method to query only unfinished transactions.
Expand Down
2 changes: 1 addition & 1 deletion ...ase/in_app_purchase_storekit/example/shared/RunnerTests/FIAPPaymentQueueDeleteTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ final class FIAPPaymentQueueDelegateTests: XCTestCase {
XCTAssertTrue(shouldContinue)
}

#if TARGET_OS_IOS
#if os(iOS)
func testShouldShowPriceConsentIfNeeded() throws {
if #available(iOS 13.4, *) {
let channelStub = MethodChannelStub()
Expand Down
4 changes: 2 additions & 2 deletions ..._app_purchase_storekit/example/shared/RunnerTests/InAppPurchaseStoreKit2PluginTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ final class InAppPurchase2PluginTests: XCTestCase {
plugin.purchase(id: "consumable", options: nil) { result in
switch result {
case .success:
XCTFail("Purchase should NOT suceed.")
XCTFail("Purchase should NOT succeed.")
case .failure(let error):
XCTAssertEqual(
error.localizedDescription,
Expand Down Expand Up @@ -393,7 +393,7 @@ final class InAppPurchase2PluginTests: XCTestCase {

plugin.purchase(id: "consumable", options: nil) { result in
switch result {
case .success(let purchase):
case .success(_):
Copy link
Contributor

@LouiseHsu LouiseHsu Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing - Im guessing you might need to keep the "let purchase" because of IAP sandbox shennanigans. I think if you dont handle the VerificationResult it freaks out. Maybe we can do this instead

case .success(let purchase):
    _ = purchase

Copy link
Member Author

@jmagman jmagman Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, this test passes on Xcode 26.2 locally.

Copy link
Member Author

@jmagman jmagman Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also passed on 16.4 locally...

Copy link
Contributor

@LouiseHsu LouiseHsu Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh thats scary

Copy link
Member Author

@jmagman jmagman Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it passed in CI when run a second time.

Copy link
Contributor

@LouiseHsu LouiseHsu Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh the tests are flaky :( thats not good

Copy link
Contributor

@LouiseHsu LouiseHsu Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol flutter/flutter#174478

purchaseExpectation.fulfill()
case .failure(let error):
XCTFail("Purchase should NOT fail. Failed with \(error)")
Expand Down
2 changes: 1 addition & 1 deletion ...in_app_purchase/in_app_purchase_storekit/example/shared/RunnerTests/TranslatorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ final class ObjectTranslatorTest: XCTestCase {
private var discountMap: [String: Any] {
// Type is being instantiated like this because of Swift naming weirdness
let type: SKProductDiscount.`Type` = .introductory
var map: [String: Any] = [
let map: [String: Any] = [
"identifier": "test offer id",
"price": "1",
"priceLocale": FIAObjectTranslator.getMapFrom(NSLocale.system),
Expand Down