-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[ci] release action uses sub action for installing flutter #10747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
| uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 | ||
| with: | ||
| fetch-depth: 0 # Fetch all history so the tool can get all the tags to determine version. | ||
| - name: "Install Flutter" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move install here because calling sub action needs to check out source code first
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/packages@9705815...039a026 2026-01-07 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from 66dd93f to f6ff152 (2 revisions) (flutter/packages#10746) 2026-01-07 47866232+chunhtai@users.noreply.github.com [ci] release action uses sub action for installing flutter (flutter/packages#10747) 2026-01-07 athom@google.com Fix html in webview_flutter doc comment (flutter/packages#10634) 2026-01-07 150208987+jalen-videotape@users.noreply.github.com [camera_web] Fixed crashing bug on camera_web 0.3.5 for Safari (flutter/packages#10595) 2026-01-07 engine-flutter-autoroll@skia.org Roll Flutter from 13b2b91 to 01d37bc (74 revisions) (flutter/packages#10745) 2026-01-07 47866232+chunhtai@users.noreply.github.com [ci] adjust github action, need to checkout repo before using local action (flutter/packages#10744) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…0747) as title, verified the use of sub action for install flutter. dedups the release workflow ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
as title, verified the use of sub action for install flutter. dedups the release workflow
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3