[camera_android_camerax] Improve documentation on cameraId parameter
#10844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsim99
added
override: no versioning needed
Contributor
Author
|
Overriding changelof and version updates because this is just documentation updates with no direct benefit to clients. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly improves the documentation across various methods in android_camera_camerax.dart by explicitly clarifying the role and usage of the cameraId parameter. These changes enhance the clarity and understanding of the API for developers, making it easier to comprehend how each method interacts with specific camera instances. The updates are consistent and directly address the stated objective of the pull request.
jesswrd
approved these changes
Jan 28, 2026
camsim99
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2026
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 29, 2026
flutter/packages@1cb2148...cd4fd61 2026-01-28 magder@google.com [quick_actions_ios] Migrate XCTest to Swift Testing (flutter/packages#10767) 2026-01-28 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Improve documentation on `cameraId` parameter (flutter/packages#10844) 2026-01-28 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Improve error messages when image capture fails (flutter/packages#10846) 2026-01-28 j.calvin.ren@gmail.com [image_picker] Transparent pressing on iOS 26 (#173453) (flutter/packages#10533) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LongCatIsLooong
pushed a commit
to LongCatIsLooong/flutter
that referenced
this pull request
Feb 6, 2026
…r#181663) flutter/packages@1cb2148...cd4fd61 2026-01-28 magder@google.com [quick_actions_ios] Migrate XCTest to Swift Testing (flutter/packages#10767) 2026-01-28 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Improve documentation on `cameraId` parameter (flutter/packages#10844) 2026-01-28 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Improve error messages when image capture fails (flutter/packages#10846) 2026-01-28 j.calvin.ren@gmail.com [image_picker] Transparent pressing on iOS 26 (flutter#173453) (flutter/packages#10533) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies what
cameraIdis used for in each of the plugin methods.Fixes flutter/flutter#126270.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3