[pigeon] Migrate XCTest to Swift Testing by jmagman · Pull Request #10905 · flutter/packages

jmagman · 2026-01-27T00:32:58Z

Adding CHANGELOG override per #10761 (comment)

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

jmagman · 2026-01-27T04:43:49Z

packages/pigeon/platform_tests/test_plugin/example/ios/RunnerTests/AllDatatypesTests.swift

+  private var correctListInMap: [AnyHashable: Any?] { ["a": 1, "b": 2, "c": correctList] }
+  private var matchingListInMap: [AnyHashable: Any?] { ["a": 1, "b": 2, "c": matchingList] }
+  private var differentListInMap: [AnyHashable: Any?] { ["a": 1, "b": 2, "c": differentList] }

-  private lazy var correctMapInList: [Any?] = ["a", 2, correctMap]
-  private lazy var matchingMapInList: [Any?] = ["a", 2, matchingMap]
-  private lazy var differentKeyMapInList: [Any?] = ["a", 2, differentKeyMap]
-  private lazy var differentValueMapInList: [Any?] = ["a", 2, differentValueMap]
+  private var correctMapInList: [Any?] { ["a", 2, correctMap] }
+  private var matchingMapInList: [Any?] { ["a", 2, matchingMap] }
+  private var differentKeyMapInList: [Any?] { ["a", 2, differentKeyMap] }
+  private var differentValueMapInList: [Any?] { ["a", 2, differentValueMap] }


Swift 6 has a new warning:

AllDatatypesTests.swift:166:48 Cannot use mutating getter on immutable value: 'self' is immutable"

So make these lazy properties computed properties instead.

gemini-code-assist

Code Review

This pull request migrates the Pigeon platform tests from XCTest to the new Swift Testing framework. The changes are extensive and mostly look correct, adopting new idioms like @Test, async/await for tests, #expect, and await confirmation.

I've found a pre-existing bug in one of the tests in EnumTests.swift where a value was being compared to itself. I've also suggested an improvement in ListTests.swift to make the test safer and more idiomatic with Swift Testing by using #require.

Additionally, I've noticed a pattern across several test files where failure cases in API callbacks record a generic "Failed" message. I've left comments with suggestions to include the specific error in the issue record for better debuggability. This would make the tests more informative when they fail.

packages/pigeon/platform_tests/test_plugin/example/ios/RunnerTests/EnumTests.swift

packages/pigeon/platform_tests/test_plugin/example/ios/RunnerTests/AllDatatypesTests.swift

packages/pigeon/platform_tests/test_plugin/example/ios/RunnerTests/AsyncHandlersTest.swift

packages/pigeon/platform_tests/test_plugin/example/ios/RunnerTests/EnumTests.swift

packages/pigeon/platform_tests/test_plugin/example/ios/RunnerTests/MultipleArityTests.swift

packages/pigeon/platform_tests/test_plugin/example/ios/RunnerTests/NullableReturnsTests.swift

packages/pigeon/platform_tests/test_plugin/example/ios/RunnerTests/PrimitiveTests.swift

packages/pigeon/platform_tests/test_plugin/example/ios/RunnerTests/ProxyApiTests.swift

packages/pigeon/platform_tests/test_plugin/example/ios/RunnerTests/RunnerTests.swift

jmagman · 2026-01-27T05:33:23Z

packages/pigeon/platform_tests/test_plugin/example/ios/Runner.xcodeproj/project.pbxproj

 		97C146FE1CF9000F007C117D /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 97C146FD1CF9000F007C117D /* Assets.xcassets */; };
 		97C147011CF9000F007C117D /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 97C146FF1CF9000F007C117D /* LaunchScreen.storyboard */; };
 		E04641FA2A46270400661C9E /* NSNullFieldTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = E04641F92A46270400661C9E /* NSNullFieldTests.swift */; };
+		F750BDEE2F28844900E3DB39 /* ProxyApiTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = F750BDED2F28844900E3DB39 /* ProxyApiTests.swift */; };


Huh, this wasn't included in the project, so wasn't actually running.

tarrinneal

THE fAiLUrE mEssage IS geNerIc. it WOULd be More HeLPFUL for dEbuGGInG TO inCLUDe tHE actUal eRROr tHaT WAS RECEivED.

Actually though, this is much nicer than before. Thank you.

jmagman · 2026-01-27T21:19:14Z

THE fAiLUrE mEssage IS geNerIc. it WOULd be More HeLPFUL for dEbuGGInG TO inCLUDe tHE actUal eRROr tHaT WAS RECEivED.

Always want to be helpful to the bots. 🙏

…10905)

flutter/packages@e37af11...1cb2148 2026-01-27 engine-flutter-autoroll@skia.org Roll Flutter from 7165649 to dfd92b7 (22 revisions) (flutter/packages#10914) 2026-01-27 magder@google.com [shared_preferences_foundation] Migrate XCTest to Swift Testing (flutter/packages#10766) 2026-01-27 magder@google.com [pigeon] Migrate XCTest to Swift Testing (flutter/packages#10905) 2026-01-27 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 8b87286 to bd7a4a6 (6 revisions) (flutter/packages#10913) 2026-01-27 47866232+chunhtai@users.noreply.github.com [ci] Add post release label to sync_release_pr workflow (flutter/packages#10864) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#181608) flutter/packages@e37af11...1cb2148 2026-01-27 engine-flutter-autoroll@skia.org Roll Flutter from 7165649 to dfd92b7 (22 revisions) (flutter/packages#10914) 2026-01-27 magder@google.com [shared_preferences_foundation] Migrate XCTest to Swift Testing (flutter/packages#10766) 2026-01-27 magder@google.com [pigeon] Migrate XCTest to Swift Testing (flutter/packages#10905) 2026-01-27 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 8b87286 to bd7a4a6 (6 revisions) (flutter/packages#10913) 2026-01-27 47866232+chunhtai@users.noreply.github.com [ci] Add post release label to sync_release_pr workflow (flutter/packages#10864) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

[pigeon] Migrate XCTest to Swift Testing

b1d0d30

jmagman added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jan 27, 2026

github-actions bot added p: pigeon platform-ios platform-macos labels Jan 27, 2026

jmagman mentioned this pull request Jan 27, 2026

Migrate iOS plugin tests from XCTest to Swift Testing flutter/flutter#180787

Open

19 tasks

Fix tests

ca7bc05

jmagman force-pushed the pigeon-st branch from 83504b7 to ca7bc05 Compare January 27, 2026 04:40

jmagman commented Jan 27, 2026

View reviewed changes

jmagman marked this pull request as ready for review January 27, 2026 05:08

jmagman requested a review from tarrinneal as a code owner January 27, 2026 05:08

gemini-code-assist bot reviewed Jan 27, 2026

View reviewed changes

Fix bug, make errors better

c1212ba

jmagman commented Jan 27, 2026

View reviewed changes

tarrinneal approved these changes Jan 27, 2026

View reviewed changes

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 27, 2026

auto-submit bot merged commit 47ba12b into flutter:main Jan 27, 2026
81 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 28, 2026

47ba12b95 [pigeon] Migrate XCTest to Swift Testing (flutter/packages#…

4fdb511

…10905)

engine-flutter-autoroll mentioned this pull request Jan 28, 2026

Roll Packages from e37af1148f45 to 1cb2148ade16 (5 revisions) flutter/flutter#181598

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 28, 2026

47ba12b95 [pigeon] Migrate XCTest to Swift Testing (flutter/packages#…

2fe9e3a

…10905)

engine-flutter-autoroll mentioned this pull request Jan 28, 2026

Roll Packages from e37af1148f45 to 1cb2148ade16 (5 revisions) flutter/flutter#181608

Merged

jmagman deleted the pigeon-st branch January 28, 2026 23:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pigeon] Migrate XCTest to Swift Testing#10905

[pigeon] Migrate XCTest to Swift Testing#10905
auto-submit[bot] merged 3 commits intoflutter:mainfrom
jmagman:pigeon-st

jmagman commented Jan 27, 2026

Uh oh!

jmagman Jan 27, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmagman Jan 27, 2026

Uh oh!

tarrinneal left a comment

Uh oh!

jmagman commented Jan 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

jmagman commented Jan 27, 2026

Pre-Review Checklist

Footnotes

Uh oh!

jmagman Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmagman Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

tarrinneal left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman commented Jan 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments