-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Isolate to Quantize #12
Conversation
Current computation method is very heavy on older devices. This shifts computation to an isolate using compute. this is only done is filters are null, since i could not find a way to pass filters/functions as message to isolate
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interesting idea, but there are some minor changes needed: try running dartfmt
over the code to format it properly.
Rect region = map["region"]; | ||
List<PaletteFilter> filters = map["filters"]; | ||
List<PaletteColor> _paletteColors =map["paletteColors"]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compute only lets one parameter to pass so I used map to pass the values, I'm not exactly sure how to pass multiple parameters, besides using a list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I mean remove the extra blank line here. There are two, when usually only one is used.
Also, fix the analyzer errors and warnings. |
Thanks for the updates @deep-gaurav! Let me know when you're done fixing the analyzer problems, and I'll take another look. |
@deep-gaurav Do you still plan to come back to this to fix the analyzer issues? |
I am closing this since there has been no follow-up. This approach is really interesting though. If somebody has the time for it, this is worth to be picked up again. |
flutter/flutter@57b5c3c...d3df8f6 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 68fc1a567195 to 01fc3c6624ce (1 revision) (flutter/flutter#135808) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4ed733d99cd5 to 68fc1a567195 (1 revision) (flutter/flutter#135807) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from d814c69abe26 to 4ed733d99cd5 (1 revision) (flutter/flutter#135801) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from f726438d4d65 to d814c69abe26 (1 revision) (flutter/flutter#135799) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0b96a82cc874 to f726438d4d65 (1 revision) (flutter/flutter#135796) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from f3a4cab69962 to 0b96a82cc874 (1 revision) (flutter/flutter#135793) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from e719b7957763 to f3a4cab69962 (2 revisions) (flutter/flutter#135792) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8939f9c1f4e4 to e719b7957763 (2 revisions) (flutter/flutter#135789) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6a13607008ed to 8939f9c1f4e4 (1 revision) (flutter/flutter#135788) 2023-09-30 32242716+ricardoamador@users.noreply.github.com Add device ready check (flutter/flutter#135526) 2023-09-30 32242716+ricardoamador@users.noreply.github.com Temporarily disable NexusLowRes, version=29 (flutter/flutter#135785) 2023-09-30 sokolovskyi.konstantin@gmail.com Cover more test/widgets tests with leak tracking #12. (flutter/flutter#135385) 2023-09-30 sokolovskyi.konstantin@gmail.com DraggableScrollableController should dispatch creation in constructor. (flutter/flutter#135423) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from d203e349781c to 6a13607008ed (2 revisions) (flutter/flutter#135780) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 48973d7f9beb to d203e349781c (5 revisions) (flutter/flutter#135776) 2023-09-29 sokolovskyi.konstantin@gmail.com ViewportOffset should dispatch creation in constructor. (flutter/flutter#135420) 2023-09-29 jacksongardner@google.com Use platform dill from the engine when compiling with dart2wasm. (flutter/flutter#134970) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from d5fcd78a879b to 48973d7f9beb (5 revisions) (flutter/flutter#135765) 2023-09-29 polinach@google.com Upgrade leak_tracker to fix flackiness. (flutter/flutter#135760) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from c52251a8b2d0 to d5fcd78a879b (2 revisions) (flutter/flutter#135755) 2023-09-29 tessertaha@gmail.com Update `Drawer` tests for M2/M3 (flutter/flutter#135752) 2023-09-29 katelovett@google.com Expose onAttach and onDetach in ScrollController subclasses (flutter/flutter#135721) 2023-09-29 jacksongardner@google.com Update the wasm bootstrap to allow access to the emscripten wrapper to skwasm. (flutter/flutter#135723) 2023-09-29 42216813+eliasyishak@users.noreply.github.com Update logic for getting `Analytics` instance from package:unified_analytics (flutter/flutter#134756) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/flutter@57b5c3c...d3df8f6 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 68fc1a567195 to 01fc3c6624ce (1 revision) (flutter/flutter#135808) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4ed733d99cd5 to 68fc1a567195 (1 revision) (flutter/flutter#135807) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from d814c69abe26 to 4ed733d99cd5 (1 revision) (flutter/flutter#135801) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from f726438d4d65 to d814c69abe26 (1 revision) (flutter/flutter#135799) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0b96a82cc874 to f726438d4d65 (1 revision) (flutter/flutter#135796) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from f3a4cab69962 to 0b96a82cc874 (1 revision) (flutter/flutter#135793) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from e719b7957763 to f3a4cab69962 (2 revisions) (flutter/flutter#135792) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8939f9c1f4e4 to e719b7957763 (2 revisions) (flutter/flutter#135789) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6a13607008ed to 8939f9c1f4e4 (1 revision) (flutter/flutter#135788) 2023-09-30 32242716+ricardoamador@users.noreply.github.com Add device ready check (flutter/flutter#135526) 2023-09-30 32242716+ricardoamador@users.noreply.github.com Temporarily disable NexusLowRes, version=29 (flutter/flutter#135785) 2023-09-30 sokolovskyi.konstantin@gmail.com Cover more test/widgets tests with leak tracking flutter#12. (flutter/flutter#135385) 2023-09-30 sokolovskyi.konstantin@gmail.com DraggableScrollableController should dispatch creation in constructor. (flutter/flutter#135423) 2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from d203e349781c to 6a13607008ed (2 revisions) (flutter/flutter#135780) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 48973d7f9beb to d203e349781c (5 revisions) (flutter/flutter#135776) 2023-09-29 sokolovskyi.konstantin@gmail.com ViewportOffset should dispatch creation in constructor. (flutter/flutter#135420) 2023-09-29 jacksongardner@google.com Use platform dill from the engine when compiling with dart2wasm. (flutter/flutter#134970) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from d5fcd78a879b to 48973d7f9beb (5 revisions) (flutter/flutter#135765) 2023-09-29 polinach@google.com Upgrade leak_tracker to fix flackiness. (flutter/flutter#135760) 2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from c52251a8b2d0 to d5fcd78a879b (2 revisions) (flutter/flutter#135755) 2023-09-29 tessertaha@gmail.com Update `Drawer` tests for M2/M3 (flutter/flutter#135752) 2023-09-29 katelovett@google.com Expose onAttach and onDetach in ScrollController subclasses (flutter/flutter#135721) 2023-09-29 jacksongardner@google.com Update the wasm bootstrap to allow access to the emscripten wrapper to skwasm. (flutter/flutter#135723) 2023-09-29 42216813+eliasyishak@users.noreply.github.com Update logic for getting `Analytics` instance from package:unified_analytics (flutter/flutter#134756) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Current computation method is very heavy on older devices.
This shifts computation to an isolate using compute.
this is only done is filters are null, since i could not find a way to pass filters/functions as message to isolate