Fix an error in calculating titleTextColor and bodyTextColor for PaletteColor. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edwardez, could you please rebase to the HEAD of the repo and push it here? I think you were unlucky in that the ref you sync'd to had some other issues: these analysis problems don't seem to be related to your change. If you don't have time, just say so and I'll create a new PR at HEAD with these changes in it. |
…tness in HSLColor. This results in a incorrect calculation of titleTextColor and bodyTextColor for PaletteColor.
edwardez
force-pushed
the
fix-luminance-calculation
branch
from
be90fc4 to
f61d405
Compare
|
Done! PTAL :) |
gspencergoog
pushed a commit
to gspencergoog/packages
that referenced
this pull request
Aug 19, 2020
stuartmorgan
pushed a commit
that referenced
this pull request
Oct 31, 2024
stuartmorgan
pushed a commit
that referenced
this pull request
Oct 31, 2024
color percentages can be floats and there can be whitespace everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix luminance calculation by using relative luminance instead of lightness in HSLColor.
This results in a incorrect calculation of titleTextColor and bodyTextColor for PaletteColor.
This fixes flutter/flutter#31592