Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

Manual version of #2221 with
fixes for the deprecation warnings that fail analysis.

Also removes analysis from packages/flutter_image/run_tests.sh, as it is
duplicated from other CI steps. The custom script should only be
runnning tests that aren't covered by standard CI steps.

No version change: // ignore directives don't affect package clients.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Manual version of flutter#2221 with
fixes for the deprecation warnings that fail analysis.

Also removes analysis from packages/flutter_image/run_tests.sh, as it is
duplicated from other CI steps. The custom script should only be
runnning tests that aren't covered by standard CI steps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants