Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SnackBar methods to ScaffoldMessenger #223

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Oct 12, 2020

cc/ @goderbauer contact for https://github.com/flutter/tests/blob/master/registry/flutter_packages.test

flutter/flutter#66504 introduced the ScaffoldMessenger widget, which allows for persistent SnackBars across Scaffolds, as well as easier management of asynchronous SnackBars. The original SnackBar methods in Scaffold are going to be deprecated. Test failures were identified in this repository in flutter/flutter#67947, so this PR is intended to migrate to the new API.

Full Migration Guide:
flutter/website#4527

References:
flutter/flutter#62921
flutter/flutter#57218

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks merged commit c2c4b33 into flutter:master Oct 12, 2020
stuartmorgan pushed a commit to stuartmorgan/packages that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants