[xdg_directories] Migrate to null safety. #273
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested: flutter test flutter pub publish --dry-run
Tested: flutter test
|
There's already an in-progress PR for this at #250, and some of the changes you've made here have already been discussed and iterated on there. Perhaps you could follow up in that PR and see if the original author is planning on following up soon on the latest comments, or is interested in having you take over? |
|
@goderbauer @stuartmorgan Since the nnbd branch is deleted and both pull requests are closed automatically, do you want me to recreate a pull request or ask the author of #250 if they want to follow through? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the xdg_directories package to null safety.
This pull request closes flutter/flutter#74836.
Tested:
flutter test
flutter pub publish --dry-run