-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[pigeon] Consolidate platform test harnesses part 1 - harnesses #2809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pigeon] Consolidate platform test harnesses part 1 - harnesses #2809
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
tarrinneal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like everything here is solid
Part 1 of #2803
Adds two plugins—one for most languages, one for alternate languages (Java and Obj-C)—to serve as native test hosts, to consolidate everything into a multi-platform test harness that uses exactly the same structure as all of the native unit tests in flutter/plugins.
This PR is a no-op in terms of the actual test script; it adds the scaffolding with nothing using it yet. Each test will be moved in a separate follow-up PR to isolate the CI issues in #2803. This portion corresponds to:
flutter create.This does preemptively remove a Cirrus CI workaround for dart-lang/pub#3618, since that is now fixed upstream, and removing it now avoids needing to update the workaround in every follow-up PR.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).