Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web_benchmarks] Update versions for upstream packages #290

Merged
merged 3 commits into from
Feb 16, 2021
Merged

[web_benchmarks] Update versions for upstream packages #290

merged 3 commits into from
Feb 16, 2021

Conversation

pennzht
Copy link
Member

@pennzht pennzht commented Feb 16, 2021 •
edited
Loading

Description

This PR updates versions for packages logging and shelf, dependencies of the web_benchmarks package, in order to resolve version conflicts during null-safe migration.

logging is updated not to resolve the Gallery version conflict (flutter/gallery#433), but to avoid future conflicts.

Issues

flutter/gallery#433

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
    • No tests were added. This is only a version bump.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
    • No documentation needed.
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@pennzht pennzht requested a review from yjbanov February 16, 2021 20:58
@yjbanov yjbanov merged commit d377e6b into flutter:master Feb 16, 2021
@yjbanov
Copy link
Contributor

yjbanov commented Feb 16, 2021

Oops! Sorry, meant to LGTM but clicked on merge instead. I hope this was ready to go. LMK if it wasn't and we need to revert.

@pennzht
Copy link
Member Author

pennzht commented Feb 17, 2021

@yjbanov

Don't worry! It is ready to go. If you are OK with it, let's publish the package.

stuartmorgan pushed a commit to stuartmorgan/packages that referenced this pull request Apr 30, 2021
@chingjun
Add compressionState to mock to avoid test failure (flutter#290)
4da6a9c 
A recent change to the Dart SDK will throw an exception if a null value is passed to an exhaustive switch statement on a non-nullable enum type.
(see dart-lang/sdk@2414b29)

Add `compressionState` to mock so that the tests don't fail when the Dart changes are released.

Related issue: flutter/flutter#66674
austinstoker pushed a commit to austinstoker/packages that referenced this pull request Apr 29, 2022
@slovnicki
[add] beaming histories to context extensions
a52c325 
	- closes flutter#290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjbanov yjbanov Awaiting requested review from yjbanov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pennzht @yjbanov