[webview_flutter_android] Fix Android lint warnings #3675

bparrishMines · 2023-04-10T14:38:25Z

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

bparrishMines · 2023-04-10T14:55:21Z

...ndroid/android/src/main/java/io/flutter/plugins/webviewflutter/CookieManagerHostApiImpl.java

@@ -30,7 +32,7 @@ public void setCookie(String url, String value) {
   * @param cookieManager The cookie manager to clear all cookies from.
   * @return Whether any cookies were removed.
   */
-  @SuppressWarnings("deprecation")
+  @SuppressWarnings({"deprecation", "RedundantSuppression"})


@stuartmorgan

This is the scenario where the javac linter and the Android gradle linter disagreed. The javac linter claims this is deprecated, but the Android lint believes this does not need a suppression.

After I did some investigation, It looks like the problem is that the javac linter doesn't understand the if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) or @RequiresApi(api = Build.VERSION_CODES.LOLLIPOP) logic. There are other instance of this throughout this plugin, and will probably show up in other plugins as well.

Potentially we should ignore the deprecation warning from the javac linter and allow the Android gradle linter to handle it?

@reidbaker FYI

If the Android lint deprecation option covers everything the javac lint one does, but automatically handles the version checks, disabling deprecation for javac in all plugins sounds good to me. The fact that the javac version made us suppress everything even when we were already doing checks was really annoying.

Hm, is in the Android lint that we run with android-lint (i.e., ./gradlew lint) that objects to the suppression, or just AS? I just hit this locally while experimenting with another plugin's warnings, and I see that in AS, but not in the android-lint lint report.

As far as I can tell, the AS linter is a third, different linter, that shows different things. (I also see things in the lint report that don't show up in AS.)

Ah, I tried it again in Android Studio and I think you're right. I must have got the error mixed up with another one. The lint command does still pass if only @SuppressWarnings("deprecation") is used. I should be able to change my local AS settings to ignore this warning.

stuartmorgan

Thanks for all the cleanup!

I added new tests to check the change I am making, or this PR is test-exempt.

The PR should also update (or remove if empty) the lint-baseline.xml file, which would serve as a test for this.

stuartmorgan · 2023-04-11T17:12:37Z

...er_android/android/src/main/java/io/flutter/plugins/webviewflutter/DisplayListenerProxy.java

@@ -118,9 +116,11 @@ private static ArrayList<DisplayListener> yoinkDisplayListeners(DisplayManager d
      return new ArrayList<>();
    }
    try {
+      //noinspection JavaReflectionMemberAccess


Are these directives for the AS linter? I've not seen them for the linters we run in CI.

Yea, I didn't realize this was unique to AS. I went ahead and removed them

...ndroid/android/src/main/java/io/flutter/plugins/webviewflutter/WebViewClientHostApiImpl.java

reidbaker · 2023-04-11T19:27:00Z

...android/android/src/main/java/io/flutter/plugins/webviewflutter/GeneratedAndroidWebView.java

@@ -22,15 +22,39 @@
 import java.util.Map;

 /** Generated class from Pigeon. */
-@SuppressWarnings({"unused", "unchecked", "CodeBlock2Expr", "RedundantSuppression"})
+@SuppressWarnings({"unused", "unchecked", "CodeBlock2Expr", "RedundantSuppression", "serial"})


For my own education did this suppression come from running pidgen?

Yes, we added this to the Pigeon generator for Java recently.

bparrishMines · 2023-04-12T19:02:35Z

@stuartmorgan I removed the baseline and finished fixing the rest of the lint errors

stuartmorgan

LGTM!

…packages#3675)

flutter/packages@d01f4ea...e4ec155 2023-04-14 stuartmorgan@google.com [shared_preferences] Remove Android lint baseline (flutter/packages#3707) 2023-04-13 37607224+AmanNegi@users.noreply.github.com [shared_preferences] Ports SharedPreferencesAndroid to Pigeon (flutter/packages#3321) 2023-04-13 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Fix Android lint warnings (flutter/packages#3675) 2023-04-13 gautier.bayzelon@gmail.com [go_router_builder] Use only one .where() (flutter/packages#3698) 2023-04-13 engine-flutter-autoroll@skia.org Roll Flutter from 3b4b149 to be45eb2 (21 revisions) (flutter/packages#3701) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

[webview_flutter_android] Fix Android lint warnings

bparrishMines added 3 commits April 10, 2023 10:31

update pigeon and fix android lint errors

bd5a6bb

Fix warning maybe

b1b6757

version bump

b3c64bd

github-actions bot added p: webview_flutter platform-android labels Apr 10, 2023

add pigeon update

0501ea2

bparrishMines changed the title ~~Fix lint errors~~ [webview_flutter_android] Fix Android lint warnings Apr 10, 2023

remove unused code

fb85d08

bparrishMines commented Apr 10, 2023

View reviewed changes

bparrishMines added 3 commits April 10, 2023 11:08

fix tests

12dd7a7

fix casting

e19410c

Merge branch 'main' of github.com:flutter/packages into fix_lint_errors

81f8162

stuartmorgan requested changes Apr 11, 2023

View reviewed changes

bparrishMines added 4 commits April 11, 2023 14:43

remove redundant suppressions and non-linter suppressions

a3cd5a1

change annotation order

ed2b59b

Merge branch 'main' of github.com:flutter/packages into fix_lint_errors

05fa18b

some annotation changes

becc5d1

reidbaker approved these changes Apr 11, 2023

View reviewed changes

stuartmorgan mentioned this pull request Apr 12, 2023

[webview_flutter] Adds platform implementations for onHttpError callback #3695

Closed

11 tasks

bparrishMines added 2 commits April 12, 2023 14:16

remove baseline

5b96a1a

fix rest of lint errors

3704cc0

bparrishMines requested a review from stuartmorgan April 12, 2023 19:02

Merge branch 'main' of github.com:flutter/packages into fix_lint_errors

ad60503

stuartmorgan approved these changes Apr 13, 2023

View reviewed changes

bparrishMines added 3 commits April 13, 2023 12:05

Merge branch 'main' of github.com:flutter/packages into fix_lint_errors

64a7bbd

Merge branch 'main' of github.com:flutter/packages into fix_lint_errors

a5c0d58

remove pubspec error

29d5fe9

bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 13, 2023

auto-submit bot merged commit d5801ea into flutter:main Apr 13, 2023

bparrishMines deleted the fix_lint_errors branch April 13, 2023 19:08

stuartmorgan mentioned this pull request Apr 13, 2023

Remove Android lint-baseline.xml files from flutter/packages flutter/flutter#88011

Open

15 tasks

engine-flutter-autoroll mentioned this pull request Apr 14, 2023

Roll Packages from d01f4eaabb54 to e4ec15590935 (5 revisions) flutter/flutter#124863

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2023

d5801ea [webview_flutter_android] Fix Android lint warnings (flutter/…

1c09de4

…packages#3675)

reidbaker mentioned this pull request Apr 25, 2023

[various] update agp and gradle for all examples in packages #3822

Merged

11 tasks

nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023

[webview_flutter_android] Fix Android lint warnings (flutter#3675)

762d159

[webview_flutter_android] Fix Android lint warnings

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[webview_flutter_android] Fix Android lint warnings #3675

[webview_flutter_android] Fix Android lint warnings #3675

bparrishMines commented Apr 10, 2023 •

edited

Loading

bparrishMines Apr 10, 2023 •

edited

Loading

stuartmorgan Apr 11, 2023 •

edited

Loading

stuartmorgan Apr 11, 2023

bparrishMines Apr 11, 2023

stuartmorgan left a comment

stuartmorgan Apr 11, 2023

bparrishMines Apr 12, 2023

reidbaker Apr 11, 2023

stuartmorgan Apr 11, 2023

bparrishMines commented Apr 12, 2023

stuartmorgan left a comment

[webview_flutter_android] Fix Android lint warnings #3675

[webview_flutter_android] Fix Android lint warnings #3675

Conversation

bparrishMines commented Apr 10, 2023 • edited Loading

Pre-launch Checklist

bparrishMines Apr 10, 2023 • edited Loading

Choose a reason for hiding this comment

stuartmorgan Apr 11, 2023 • edited Loading

Choose a reason for hiding this comment

stuartmorgan Apr 11, 2023

Choose a reason for hiding this comment

bparrishMines Apr 11, 2023

Choose a reason for hiding this comment

stuartmorgan left a comment

Choose a reason for hiding this comment

stuartmorgan Apr 11, 2023

Choose a reason for hiding this comment

bparrishMines Apr 12, 2023

Choose a reason for hiding this comment

reidbaker Apr 11, 2023

Choose a reason for hiding this comment

stuartmorgan Apr 11, 2023

Choose a reason for hiding this comment

bparrishMines commented Apr 12, 2023

stuartmorgan left a comment

Choose a reason for hiding this comment

bparrishMines commented Apr 10, 2023 •

edited

Loading

bparrishMines Apr 10, 2023 •

edited

Loading

stuartmorgan Apr 11, 2023 •

edited

Loading