[google_maps_flutter_android] Fix Android lint warnings #3751

mgmix · 2023-04-18T06:11:20Z

Fixed the Android lint warning shown in lint-baseline.xml and removed the baseline.

Pre-launch Checklist

flutter-dashboard · 2023-04-18T06:11:23Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

reidbaker · 2023-04-18T14:29:06Z

Thank you for your contribution. It looks like the tests are failing. Before we review the PR, please see what you can do to resolve the test failures. If you are unsure how to proceed, please reach out for help on the #hackers-new channel.

@gmackall the tests are failing on the duplicate class issue I think you have seen before but I dont see any updated dependencies that would introduce that class of error.

mgmix · 2023-04-21T01:34:45Z

@reidbaker Thank you, I fixed the part that was causing the problem and it passed all the tests, could you please check it again?

reidbaker · 2023-04-24T17:42:57Z

...flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java

@@ -60,7 +60,7 @@
  private final int id;
  private final MethodChannel methodChannel;
  private final GoogleMapOptions options;
-  @Nullable private MapView mapView;
+  @Nullable MapView mapView;


For this and the other private changes in this file can you use a smaller scope than public? Specifically I think for all of these synthetic method calls you can use protected instead.
See https://stackoverflow.com/questions/4501324/synthetic-accessor-method-warning for more information.

Thank you! I restored the private scope modification in the GoogleMapController.java file, and after replacing the anonymous class GoogleMap.OnMapLoadedCallback() with a lambda expression, I confirmed that the synthetic-accessor warning no longer occurs. 4cbbc06

reidbaker · 2023-04-24T17:46:32Z

...tter_android/android/src/main/java/io/flutter/plugins/googlemaps/TileProviderController.java

-  private final String tileOverlayId;
-  private final MethodChannel methodChannel;
-  private final Handler handler = new Handler(Looper.getMainLooper());
+  final String tileOverlayId;


Can you make these SyntheticAccessor violations protected?

Apply to protected scope 496560e

Can you make these SyntheticAccessor violations protected?

@reidbaker Out of curiosity, why protected? protected is actually slightly more visible than the default Java access (package private).

reidbaker · 2023-04-24T17:47:41Z

2 small changes but this looks good. Once those are fixed I am ready to approve.

Thank you for helping make flutter better :)

gmackall · 2023-04-24T18:06:23Z

Thank you for your contribution. It looks like the tests are failing. Before we review the PR, please see what you can do to resolve the test failures. If you are unsure how to proceed, please reach out for help on the #hackers-new channel.

@gmackall the tests are failing on the duplicate class issue I think you have seen before but I dont see any updated dependencies that would introduce that class of error.

Sorry, missed this ping last week. Is the failure you are referring to the one with the message

Runtime JAR files in the classpath should have the same version. These files were found in the classpath:

That ran here? Asking because that's the most similar message I see but not sure if there was an identical one that failed, but the logs have since expired.

If so, I don't think that message is caused by this change, it's actually still there on the latest successful test run if you scroll down to the "run lint" instruction.

anonymous class `GoogleMap.OnMapLoadedCallback()` replace lambda expression. and resotred private scope

resolve conflict

gmackall

This LGTM as well. Thanks for the contributions (here and in local auth)!

…ter/packages#3751)

Roll Packages from 7e3f5da to de6131d (41 revisions) flutter/packages@7e3f5da...de6131d 2023-05-01 reidbaker@google.com I122213 update non examples (flutter/packages#3846) 2023-04-29 47866232+chunhtai@users.noreply.github.com [go_router] Cleans up route match API and introduces dart fix (flutter/packages#3819) 2023-04-29 43054281+camsim99@users.noreply.github.com [camerax] Add `LifecycleOwner` Proxy (flutter/packages#3837) 2023-04-29 stuartmorgan@google.com [file_selector] Add getDirectoryPaths implementation for Windows (flutter/packages#3704) 2023-04-29 stuartmorgan@google.com [various] Update Android example min SDKs (flutter/packages#3847) 2023-04-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.2.12 to 2.3.2 (flutter/packages#3838) 2023-04-28 43054281+camsim99@users.noreply.github.com [camerax] Implement Image Streaming (flutter/packages#3454) 2023-04-28 reidbaker@google.com [various] update agp and gradle for all examples in packages (flutter/packages#3822) 2023-04-28 54558023+keyonghan@users.noreply.github.com Update xcode to 14c18 (flutter/packages#3774) 2023-04-28 andrewjohncoutts@gmail.com [camera_android] Add NV21 as an image stream format #3277 (flutter/packages#3639) 2023-04-28 gautier.bayzelon@gmail.com [go_router] Remove unused navigator keys (flutter/packages#3708) 2023-04-28 JeroenWeener@users.noreply.github.com [image_picker] Move I/O operations to a separate thread (flutter/packages#3506) 2023-04-28 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.20 to 1.8.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#3824) 2023-04-28 stuartmorgan@google.com [pigeon] Reland: Add an initial example app (flutter/packages#3832) 2023-04-28 engine-flutter-autoroll@skia.org Roll Flutter from c9004ff to 66fa4c5 (68 revisions) (flutter/packages#3830) 2023-04-28 stuartmorgan@google.com [various] Conditionalize the namespace in all Android plugins (flutter/packages#3836) 2023-04-27 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.billingclient:billing from 5.1.0 to 5.2.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#3672) 2023-04-27 ychris@google.com [auick_action_ios] Retries multiple times to not fail ci when there is a flake (flutter/packages#3823) 2023-04-26 magder@google.com Swap some iOS package CODEOWNERS (flutter/packages#3793) 2023-04-26 stuartmorgan@google.com [various] Add `targetCompatibility` to build.gradle (flutter/packages#3825) 2023-04-26 stuartmorgan@google.com [various] Set cmake_policy versions (flutter/packages#3828) 2023-04-26 stuartmorgan@google.com [path_provider] Allow `win32` up to version 4.x (flutter/packages#3820) 2023-04-26 stuartmorgan@google.com [tool] Move Android lint checks (flutter/packages#3816) 2023-04-25 evace93@gmail.com [google_maps_flutter_android] Fix Android lint warnings (flutter/packages#3751) 2023-04-25 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.5.0 to 1.6.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#3381) 2023-04-25 jason-simmons@users.noreply.github.com Update test golden images for the latest Skia roll (flutter/packages#3787) 2023-04-25 stuartmorgan@google.com [various] Adds Android namespace (flutter/packages#3791) 2023-04-25 reidbaker@google.com [shared_preferences] Update gradle/agp in example apps (flutter/packages#3809) 2023-04-24 43640732+dancamdev@users.noreply.github.com [go_router] Adds name to TypedGoRoute (flutter/packages#3702) 2023-04-22 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Adds support to receive permission requests (flutter/packages#3543) 2023-04-21 stuartmorgan@google.com [google_sign_in] Fix Android Java warnings (flutter/packages#3762) 2023-04-21 stuartmorgan@google.com [local_auth] Fix enum return on Android (flutter/packages#3780) 2023-04-21 stuartmorgan@google.com [pigeon] Warn when trying to use enums in collections (flutter/packages#3782) 2023-04-21 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] [webview_flutter_wkwebview] Platform implementations for supporting permission requests (flutter/packages#3792) 2023-04-21 scheglov@google.com [pigeon] Update for compatibility with a future change to the analyzer. (flutter/packages#3789) 2023-04-21 10687576+bparrishMines@users.noreply.github.com [camera_android] Fix Android lint warnings (flutter/packages#3716) 2023-04-21 10687576+bparrishMines@users.noreply.github.com [webview_flutter_platform_interface] Adds method to receive permission requests (flutter/packages#3767) 2023-04-21 magder@google.com [image_picker_ios] In unit test write and read kCGImagePropertyExifUserComment property (flutter/packages#3783) 2023-04-21 widrans@gmail.com [go_router_builder] Fixed the return value of the generated push method (flutter/packages#3650) 2023-04-21 JeroenWeener@users.noreply.github.com [image_picker] Mention `launchMode: singleInstance` in README (flutter/packages#3759) 2023-04-21 stuartmorgan@google.com Revert "[pigeon] Add an initial example app" (flutter/packages#3785) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human ...

Fixed the Android lint warning shown in `lint-baseline.xml` and removed the baseline. Part of flutter/flutter#88011

mgmix added 2 commits April 18, 2023 15:01

fix: lint issue and remove lint-baseline

aa2c409

bump up version to 2.4.11

56fb7f0

mgmix requested a review from reidbaker as a code owner April 18, 2023 06:11

flutter-dashboard bot added the needs tests label Apr 18, 2023

github-actions bot added p: google_maps_flutter platform-android labels Apr 18, 2023

reidbaker requested a review from gmackall April 18, 2023 14:28

mgmix added 4 commits April 19, 2023 10:26

fix: remove unnecessary line changes

4e4c258

fix: remove baseline option from build.gradle

241ff6f

Merge branch 'main' into google_maps_flutter_android_lint

cbbd026

Merge branch 'main' into google_maps_flutter_android_lint

7e5277b

reidbaker reviewed Apr 24, 2023

View reviewed changes

Merge branch 'main' into google_maps_flutter_android_lint

1128f17

mgmix and others added 3 commits April 25, 2023 18:52

fix: apply private scope

4cbbc06

anonymous class `GoogleMap.OnMapLoadedCallback()` replace lambda expression. and resotred private scope

fix: apply protected scope

496560e

Merge branch 'main' into google_maps_flutter_android_lint

694eae4

reidbaker approved these changes Apr 25, 2023

View reviewed changes

mgmix added 2 commits April 26, 2023 01:07

Merge branch 'main' into google_maps_flutter_android_lint

4794b9b

bump version

d9a0c49

resolve conflict

gmackall approved these changes Apr 25, 2023

View reviewed changes

gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 25, 2023

auto-submit bot merged commit 501db27 into flutter:main Apr 25, 2023

mgmix deleted the google_maps_flutter_android_lint branch April 26, 2023 01:41

stuartmorgan mentioned this pull request Apr 26, 2023

Remove Android lint-baseline.xml files from flutter/packages flutter/flutter#88011

Open

15 tasks

engine-flutter-autoroll mentioned this pull request May 1, 2023

Roll Packages from 7e3f5da42e81 to b01736711cc7 (40 revisions) flutter/flutter#125799

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2023

501db27 [google_maps_flutter_android] Fix Android lint warnings (flut…

ab024c5

…ter/packages#3751)

engine-flutter-autoroll mentioned this pull request May 1, 2023

Roll Packages from 7e3f5da42e81 to de6131dbe4f7 (41 revisions) flutter/flutter#125811

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2023

501db27 [google_maps_flutter_android] Fix Android lint warnings (flut…

cfa13ca

…ter/packages#3751)

nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023

[google_maps_flutter_android] Fix Android lint warnings (flutter#3751)

7de6c1a

Fixed the Android lint warning shown in `lint-baseline.xml` and removed the baseline. Part of flutter/flutter#88011

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[google_maps_flutter_android] Fix Android lint warnings #3751

[google_maps_flutter_android] Fix Android lint warnings #3751

mgmix commented Apr 18, 2023 •

edited

Loading

flutter-dashboard bot commented Apr 18, 2023

reidbaker commented Apr 18, 2023

mgmix commented Apr 21, 2023

reidbaker Apr 24, 2023

mgmix Apr 25, 2023

reidbaker Apr 24, 2023

mgmix Apr 25, 2023

stuartmorgan Apr 25, 2023

reidbaker commented Apr 24, 2023

gmackall commented Apr 24, 2023

gmackall left a comment

[google_maps_flutter_android] Fix Android lint warnings #3751

[google_maps_flutter_android] Fix Android lint warnings #3751

Conversation

mgmix commented Apr 18, 2023 • edited Loading

Pre-launch Checklist

flutter-dashboard bot commented Apr 18, 2023

reidbaker commented Apr 18, 2023

mgmix commented Apr 21, 2023

reidbaker Apr 24, 2023

Choose a reason for hiding this comment

mgmix Apr 25, 2023

Choose a reason for hiding this comment

reidbaker Apr 24, 2023

Choose a reason for hiding this comment

mgmix Apr 25, 2023

Choose a reason for hiding this comment

stuartmorgan Apr 25, 2023

Choose a reason for hiding this comment

reidbaker commented Apr 24, 2023

gmackall commented Apr 24, 2023

gmackall left a comment

Choose a reason for hiding this comment

mgmix commented Apr 18, 2023 •

edited

Loading