Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go_router] change fix_data.yaml uris to be absolute to fix lints #3877

Merged
merged 53 commits into from
May 11, 2023
Merged
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
416612f
change fix_data uris to be absolute to fix lints
ahmednfwela May 1, 2023
d6bcf4f
Merge branch 'main' into fix-lints
ahmednfwela May 1, 2023
17ff4d1
changed version
ahmednfwela May 1, 2023
280bb99
Merge branch 'fix-lints' of github.com:Bdaya-Dev/packages into fix-lints
ahmednfwela May 1, 2023
c4a70c7
add both relative and absoulte paths to uri
ahmednfwela May 2, 2023
082bd09
added tests
ahmednfwela May 2, 2023
6dd50ca
create a temp folder instead
ahmednfwela May 2, 2023
95a3b1e
Merge branch 'main' into fix-lints
ahmednfwela May 2, 2023
d8b05ba
Merge branch 'main' into fix-lints
ahmednfwela May 2, 2023
22979c1
demonstrate testPubVersion
ahmednfwela May 2, 2023
7fd3b72
Merge branch 'fix-lints' of github.com:Bdaya-Dev/packages into fix-lints
ahmednfwela May 2, 2023
84abe08
Merge branch 'main' into fix-lints
ahmednfwela May 2, 2023
3c15fd1
remove testPubVersion entirely
ahmednfwela May 2, 2023
97fb307
Merge branch 'fix-lints' of github.com:Bdaya-Dev/packages into fix-lints
ahmednfwela May 2, 2023
89b929e
enable test for windows too
ahmednfwela May 2, 2023
c0eddc0
dart format to please the CI
ahmednfwela May 2, 2023
6131a59
Merge branch 'main' of https://github.com/flutter/packages into fix-l…
ahmednfwela May 2, 2023
06a65d5
address comments
ahmednfwela May 2, 2023
6b730ca
change comments
ahmednfwela May 2, 2023
c893a19
Merge branch 'main' into fix-lints
ahmednfwela May 2, 2023
769468a
Merge branch 'main' of https://github.com/flutter/packages into fix-l…
ahmednfwela May 2, 2023
1cdb2c0
Merge branch 'fix-lints' of github.com:Bdaya-Dev/packages into fix-lints
ahmednfwela May 2, 2023
dc99f47
allow io, yaml_edit since they are both dart owned
ahmednfwela May 2, 2023
9c08c45
Merge branch 'main' into fix-lints
ahmednfwela May 2, 2023
a1914d4
Merge branch 'main' into fix-lints
ahmednfwela May 2, 2023
2dd6f84
Merge branch 'main' of https://github.com/flutter/packages into fix-l…
ahmednfwela May 2, 2023
9cbbaa1
Merge branch 'fix-lints' of github.com:Bdaya-Dev/packages into fix-lints
ahmednfwela May 2, 2023
b0445fa
cleanUp
ahmednfwela May 2, 2023
78a6b4d
Apply suggestions from code review
ahmednfwela May 3, 2023
9c78f19
Merge branch 'main' into fix-lints
ahmednfwela May 3, 2023
78cb45c
Trigger
ahmednfwela May 3, 2023
8a0701c
Merge branch 'main' of https://github.com/flutter/packages into fix-l…
ahmednfwela May 3, 2023
4877b08
Merge branch 'fix-lints' of github.com:Bdaya-Dev/packages into fix-lints
ahmednfwela May 3, 2023
cda4ad7
Merge branch 'main' of https://github.com/flutter/packages into fix-l…
ahmednfwela May 4, 2023
258871f
reworked tests + added comments
ahmednfwela May 4, 2023
91e8973
small refactor
ahmednfwela May 4, 2023
a836a06
dart format
ahmednfwela May 4, 2023
025ffbc
Merge branch 'main' into fix-lints
ahmednfwela May 5, 2023
2c43ec5
address comments
ahmednfwela May 5, 2023
b64bc83
Merge branch 'main' of https://github.com/flutter/packages into fix-l…
ahmednfwela May 5, 2023
48c3ead
Merge branch 'fix-lints' of github.com:Bdaya-Dev/packages into fix-lints
ahmednfwela May 5, 2023
70ad1c9
Trigger CI
ahmednfwela May 5, 2023
751f84c
Merge branch 'main' into fix-lints
ahmednfwela May 6, 2023
e06e62f
Merge branch 'main' into fix-lints
ahmednfwela May 8, 2023
636b77b
Merge branch 'main' into fix-lints
ahmednfwela May 9, 2023
3ef6158
Merge branch 'main' of https://github.com/flutter/packages into fix-l…
ahmednfwela May 9, 2023
f023598
Merge branch 'fix-lints' of github.com:Bdaya-Dev/packages into fix-lints
ahmednfwela May 9, 2023
11e168d
address review
ahmednfwela May 9, 2023
1bed8f8
address review
ahmednfwela May 9, 2023
932e272
Merge branch 'main' into fix-lints
ahmednfwela May 9, 2023
219b9b0
format
ahmednfwela May 10, 2023
0ee09bb
Merge branch 'main' into fix-lints
ahmednfwela May 10, 2023
2d62b84
Merge branch 'main' into fix-lints
ahmednfwela May 11, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into fix-lints
ahmednfwela authored May 2, 2023
commit a1914d42e3f385e78dc48f5df98d595253b1008e

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.