-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[camerax] Publish plugin #3896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[camerax] Publish plugin #3896
Conversation
|
cc @gmackall for reference if you want to publish plugin before I get to it! |
|
@stuartmorgan for publishing this PR, I tried to excluding the plugin from building |
What I would do is instead exclude
|
| * Implements image streaming. | ||
| * Provides LifecycleOwner implementation for Activities that use the plugin that do not implement it themselves. | ||
| * Implements retrieval of camera information. | ||
| * Initial release of this `camera` implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest removing every entry except for this line (since from a client perspective there's nothing that these incremental changes are relative to, this being the first release), and then expanding this a bit to have a summary of what is implemented and a pointer to the readme for details.
| version: 0.5.0 | ||
|
|
||
| environment: | ||
| sdk: ">=2.18.0 <4.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this ever actually been run with 3.3? If not you may want to start it at 3.7.
|
Will land this after the following land:
|
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
1 similar comment
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🚢
| * Implements image streaming. | ||
| * Provides LifecycleOwner implementation for Activities that use the plugin that do not implement it themselves. | ||
| * Implements retrieval of camera information. | ||
| * Initial release of this `camera` implementation that supports image capture, video recording, displaying a live camera preview, and image streaming. See [`README.md`](README.md) for more details on the limitations of this implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: consider a formatted list:
* Initial release of this `camera` implementation that supports:
* image capture
* video recording
* displaying a live camera preview
* image streaming
See [`README.md`](README.md) for more details on the limitations of this implementation.
|
test-exempt: configuration change |
gmackall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Publishes `camera_android_camerax` plugin as version 0.5.0. **Reminder to whoever lands this PR**: Ping @/stuartmorgan to manually change package owner after landing this.
Publishes
camera_android_cameraxplugin as version 0.5.0.Reminder to whoever lands this PR: Ping @/stuartmorgan to manually change package owner after landing this.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).